Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3852)

Unified Diff: chrome/common/extensions/extension_action.h

Issue 276010: Remove the implicit wrench menu items for browser actions. (Closed)
Patch Set: Rebase Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/common/extensions/extension_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_action.h
diff --git a/chrome/common/extensions/extension_action.h b/chrome/common/extensions/extension_action.h
index 046ab636c999987a5856a8b6503dc6a622b4fb5e..1577224f9b704bfd3378cdb7f0c2782eac5ab775 100644
--- a/chrome/common/extensions/extension_action.h
+++ b/chrome/common/extensions/extension_action.h
@@ -25,8 +25,6 @@ class ExtensionAction {
BROWSER_ACTION = 1,
} ExtensionActionType;
- int command_id() const { return command_id_; }
-
std::string id() const { return id_; }
void set_id(const std::string& id) { id_ = id; }
@@ -55,8 +53,6 @@ class ExtensionAction {
bool is_popup() const { return !popup_url_.is_empty(); }
private:
- static int next_command_id_;
-
// The id for the ExtensionAction, for example: "RssPageAction".
// For BrowserActions this is blank.
std::string id_;
@@ -74,10 +70,6 @@ class ExtensionAction {
// The paths to the icons that this PageIcon can show.
std::vector<std::string> icon_paths_;
- // An integer for use with the browser's command system. These should always
- // be in the range [IDC_BROWSER_ACTION_FIRST, IDC_BROWSER_ACTION_LAST].
- int command_id_;
-
// If the action has a popup, it has a URL and a height.
GURL popup_url_;
int popup_height_;
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/common/extensions/extension_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698