Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 2760093002: Making callbacks in Android ChildProcessLauncher generic. (Closed)
Patch Set: Synced Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
index f6a0f8e7e82e468279d921c5bb60dee463fda10e..12bc41ce94a71125e9ad6b60fcf946205a1ddae0 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
@@ -22,11 +22,12 @@ import org.chromium.base.TraceEvent;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.process_launcher.ChildProcessCreationParams;
import org.chromium.base.process_launcher.FileDescriptorInfo;
-import org.chromium.content.common.IChildProcessCallback;
import org.chromium.content.common.IChildProcessService;
import java.io.IOException;
+import javax.annotation.Nullable;
+
/**
* Manages a connection between the browser activity and a child service.
*/
@@ -90,10 +91,10 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
private static class ConnectionParams {
final String[] mCommandLine;
final FileDescriptorInfo[] mFilesToBeMapped;
- final IChildProcessCallback mCallback;
+ final IBinder mCallback;
- ConnectionParams(String[] commandLine, FileDescriptorInfo[] filesToBeMapped,
- IChildProcessCallback callback) {
+ ConnectionParams(
+ String[] commandLine, FileDescriptorInfo[] filesToBeMapped, IBinder callback) {
mCommandLine = commandLine;
mFilesToBeMapped = filesToBeMapped;
mCallback = callback;
@@ -349,7 +350,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
@Override
public void setupConnection(String[] commandLine, FileDescriptorInfo[] filesToBeMapped,
- IChildProcessCallback processCallback, ConnectionCallback connectionCallback) {
+ @Nullable IBinder callback, ConnectionCallback connectionCallback) {
synchronized (mLock) {
assert mConnectionParams == null;
if (mServiceDisconnected) {
@@ -360,8 +361,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
try {
TraceEvent.begin("ChildProcessConnectionImpl.setupConnection");
mConnectionCallback = connectionCallback;
- mConnectionParams =
- new ConnectionParams(commandLine, filesToBeMapped, processCallback);
+ mConnectionParams = new ConnectionParams(commandLine, filesToBeMapped, callback);
// Run the setup if the service is already connected. If not,
// doConnectionSetupLocked() will be called from onServiceConnected().
if (mServiceConnectComplete) {

Powered by Google App Engine
This is Rietveld 408576698