Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: components/cronet/ios/Cronet.mm

Issue 2760073002: [cronet] Expose API to set experimental options (Closed)
Patch Set: add sslkeylogfile test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/Cronet.mm
diff --git a/components/cronet/ios/Cronet.mm b/components/cronet/ios/Cronet.mm
index b6aaeb13eab15f2d59f7f9b3bfd0db6a5aafc4f4..f3bd01570081ab6f77eb8253fed4187b46e2a34c 100644
--- a/components/cronet/ios/Cronet.mm
+++ b/components/cronet/ios/Cronet.mm
@@ -37,6 +37,7 @@ BOOL gQuicEnabled = NO;
cronet::URLRequestContextConfig::HttpCacheType gHttpCache =
cronet::URLRequestContextConfig::HttpCacheType::DISK;
ScopedVector<cronet::URLRequestContextConfig::QuicHint> gQuicHints;
+NSString* gExperimentalOptions = @"{}";
NSString* gUserAgent = nil;
BOOL gUserAgentPartial = NO;
NSString* gSslKeyLogFileName = nil;
@@ -167,6 +168,11 @@ class CronetHttpProtocolHandlerDelegate
base::SysNSStringToUTF8(host), port, altPort));
}
++ (void)setExperimentalOptions:(NSString*)experimentalOptions {
+ [self checkNotStarted];
+ gExperimentalOptions = experimentalOptions;
+}
+
+ (void)setUserAgent:(NSString*)userAgent partial:(BOOL)partial {
[self checkNotStarted];
gUserAgent = userAgent;
@@ -175,7 +181,7 @@ class CronetHttpProtocolHandlerDelegate
+ (void)setSslKeyLogFileName:(NSString*)sslKeyLogFileName {
[self checkNotStarted];
- gSslKeyLogFileName = sslKeyLogFileName;
+ gSslKeyLogFileName = [self getNetLogPathForFile:sslKeyLogFileName];
}
+ (void)setHttpCacheType:(CRNHttpCacheType)httpCacheType {
@@ -212,6 +218,8 @@ class CronetHttpProtocolHandlerDelegate
gChromeNet.Get()->set_http2_enabled(gHttp2Enabled);
gChromeNet.Get()->set_quic_enabled(gQuicEnabled);
+ gChromeNet.Get()->set_experimental_options(
+ base::SysNSStringToUTF8(gExperimentalOptions));
gChromeNet.Get()->set_http_cache(gHttpCache);
gChromeNet.Get()->set_ssl_key_log_file_name(
base::SysNSStringToUTF8(gSslKeyLogFileName));

Powered by Google App Engine
This is Rietveld 408576698