Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: components/cronet/ios/cronet_environment.mm

Issue 2760073002: [cronet] Expose API to set experimental options (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/cronet_environment.mm
diff --git a/components/cronet/ios/cronet_environment.mm b/components/cronet/ios/cronet_environment.mm
index 40fb6ac9bedadccaa129f0b50bd2ecff31a0567d..1532d34c173fac973c447117c4e2872deee4008e 100644
--- a/components/cronet/ios/cronet_environment.mm
+++ b/components/cronet/ios/cronet_environment.mm
@@ -221,6 +221,7 @@ CronetEnvironment::CronetEnvironment(const std::string& user_agent,
bool user_agent_partial)
: http2_enabled_(false),
quic_enabled_(false),
+ experimental_options_("{}"),
mef 2017/03/21 20:44:57 nit: I don't think this is necessary as it is cove
lilyhoughton 2017/03/22 13:40:55 Done. Should I have Obj-C default be an empty str
mef 2017/03/22 19:18:26 I think so. It seems that on Android they default
http_cache_(URLRequestContextConfig::HttpCacheType::DISK),
user_agent_(user_agent),
user_agent_partial_(user_agent_partial),
@@ -293,6 +294,8 @@ void CronetEnvironment::InitializeOnNetworkThread() {
cache_path.value(); // Storage path for http cache and cookie storage.
context_config_builder.user_agent =
user_agent_; // User-Agent request header field.
+ context_config_builder.experimental_options =
mef 2017/03/21 20:44:58 I think we also need to do something similar to Cr
lilyhoughton 2017/03/22 13:40:55 Acknowledged.
+ experimental_options_; // Set experimental Cronet options.
context_config_builder.mock_cert_verifier = std::move(
mock_cert_verifier_); // MockCertVerifier to use for testing purposes.
std::unique_ptr<URLRequestContextConfig> config =
« components/cronet/ios/cronet_environment.h ('K') | « components/cronet/ios/cronet_environment.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698