Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/browser/previews/previews_service.cc

Issue 2760063002: Add support to previews/ for Server LoFi and LitePages (Closed)
Patch Set: comment fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/previews/previews_service.cc
diff --git a/chrome/browser/previews/previews_service.cc b/chrome/browser/previews/previews_service.cc
index 8ddcfd18ca285b87f1c1733f6bb92f6b5b9896d2..22d879a9ad09314bf9e116d8c7bd01da01658155 100644
--- a/chrome/browser/previews/previews_service.cc
+++ b/chrome/browser/previews/previews_service.cc
@@ -10,6 +10,7 @@
#include "base/sequenced_task_runner.h"
#include "base/threading/sequenced_worker_pool.h"
#include "chrome/common/chrome_constants.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
#include "components/previews/core/previews_experiments.h"
#include "components/previews/core/previews_io_data.h"
#include "components/previews/core/previews_opt_out_store.h"
@@ -24,8 +25,14 @@ bool IsPreviewsTypeEnabled(previews::PreviewsType type) {
switch (type) {
case previews::PreviewsType::OFFLINE:
return previews::params::IsOfflinePreviewsEnabled();
- case previews::PreviewsType::CLIENT_LOFI:
- return previews::params::IsClientLoFiEnabled();
+ case previews::PreviewsType::LOFI:
+ return previews::params::IsClientLoFiEnabled() ||
+ data_reduction_proxy::params::IsLoFiOnViaFlags() ||
+ data_reduction_proxy::params::IsIncludedInLoFiEnabledFieldTrial();
+ case previews::PreviewsType::LITE_PAGE:
+ return (data_reduction_proxy::params::IsLoFiOnViaFlags() &&
+ data_reduction_proxy::params::AreLitePagesEnabledViaFlags()) ||
+ data_reduction_proxy::params::IsIncludedInLitePageFieldTrial();
case previews::PreviewsType::NONE:
case previews::PreviewsType::LAST:
break;
@@ -40,8 +47,10 @@ int GetPreviewsTypeVersion(previews::PreviewsType type) {
switch (type) {
case previews::PreviewsType::OFFLINE:
return previews::params::OfflinePreviewsVersion();
- case previews::PreviewsType::CLIENT_LOFI:
+ case previews::PreviewsType::LOFI:
return previews::params::ClientLoFiVersion();
+ case previews::PreviewsType::LITE_PAGE:
+ return data_reduction_proxy::params::LitePageVersion();
case previews::PreviewsType::NONE:
case previews::PreviewsType::LAST:
break;

Powered by Google App Engine
This is Rietveld 408576698