Chromium Code Reviews| Index: components/previews/core/previews_decider.h |
| diff --git a/components/previews/core/previews_decider.h b/components/previews/core/previews_decider.h |
| index f293c87c1ad0f621e85cf0756f6872cf0c2f6c60..b39e38e43473d261d56481599feba4a2f9f061b4 100644 |
| --- a/components/previews/core/previews_decider.h |
| +++ b/components/previews/core/previews_decider.h |
| @@ -7,6 +7,8 @@ |
| #include "components/previews/core/previews_experiments.h" |
| +#include "net/nqe/effective_connection_type.h" |
| + |
| namespace net { |
| class URLRequest; |
| } |
| @@ -15,7 +17,16 @@ namespace previews { |
| class PreviewsDecider { |
| public: |
| - // Whether |request| is allowed to show a preview of |type|. |
| + // Whether |request| is allowed to show a preview of |type|. Previews that do |
| + // not supply a network quality in |
| + // GetEffectiveConnectionTypeThresholdForPreviewsType() should check the |
| + // network quality before calling ShouldAllowPreview. |
| + virtual bool ShouldAllowPreview( |
|
tbansal1
2017/05/05 20:34:39
add comments for the args.
RyanSturm
2017/05/05 20:51:35
Done.
|
| + const net::URLRequest& request, |
| + PreviewsType type, |
| + net::EffectiveConnectionType effective_connection_type) const = 0; |
| + |
| + // Same as above, but uses the previews default EffectiveConnectionType. |
| virtual bool ShouldAllowPreview(const net::URLRequest& request, |
| PreviewsType type) const = 0; |