Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: components/previews/core/previews_io_data_unittest.cc

Issue 2760063002: Add support to previews/ for Server LoFi and LitePages (Closed)
Patch Set: build fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/core/previews_io_data_unittest.cc
diff --git a/components/previews/core/previews_io_data_unittest.cc b/components/previews/core/previews_io_data_unittest.cc
index 23b1bac9a3a2007ad4e929db67761845c9aa64fa..beb12beaeacf7866458aebf7f7dba798437942d3 100644
--- a/components/previews/core/previews_io_data_unittest.cc
+++ b/components/previews/core/previews_io_data_unittest.cc
@@ -222,6 +222,12 @@ TEST_F(PreviewsIODataTest, TestShouldAllowPreview) {
"Previews.EligibilityReason.Offline",
static_cast<int>(PreviewsEligibilityReason::NETWORK_NOT_SLOW), 1);
+ // LitePage makes its own decision about network quality.
+ EXPECT_TRUE(io_data()->ShouldAllowPreview(*request, PreviewsType::LITE_PAGE));
+ histogram_tester.ExpectBucketCount(
+ "Previews.EligibilityReason.LitePage",
+ static_cast<int>(PreviewsEligibilityReason::ALLOWED), 1);
+
// Set NQE type to slow.
network_quality_estimator.set_effective_connection_type(
net::EFFECTIVE_CONNECTION_TYPE_SLOW_2G);
@@ -230,9 +236,14 @@ TEST_F(PreviewsIODataTest, TestShouldAllowPreview) {
EXPECT_FALSE(io_data()->ShouldAllowPreview(*request, PreviewsType::OFFLINE));
histogram_tester.ExpectBucketCount(
"Previews.EligibilityReason.Offline",
- static_cast<int>(
- PreviewsEligibilityReason::RELOAD_DISALLOWED_FOR_OFFLINE),
- 1);
+ static_cast<int>(PreviewsEligibilityReason::RELOAD_DISALLOWED), 1);
+
+ // Server LoFi ignores reload when deciding to show the preview.
+ EXPECT_TRUE(
+ io_data()->ShouldAllowPreview(*request, PreviewsType::SERVER_LOFI));
+ histogram_tester.ExpectBucketCount(
+ "Previews.EligibilityReason.ServerLoFi",
+ static_cast<int>(PreviewsEligibilityReason::ALLOWED), 1);
request->SetLoadFlags(0);
EXPECT_TRUE(io_data()->ShouldAllowPreview(*request, PreviewsType::OFFLINE));

Powered by Google App Engine
This is Rietveld 408576698