tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index cc4c904c2f965738ab447956756f06dcc9281668..c163ab7608f8d6fad33c6deba14555f1dec672da 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -55390,43 +55390,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 <histogram name="Previews.EligibilityReason" enum="PreviewsEligibilityReason">
   <owner>ryansturm@chromium.org</owner>
   <summary>
-    Whether a particular preview was allowed to be shown or the reason the
-    preview could not be shown to the user.
+    When evaluating whether to show a user a preview, the preview might be
+    disallowed for various reasons. If the preview is disallowed, then this
+    reports the reason for disallowing it. If the preview is allowed, then this
+    reports &quot;Previews Allowed&quot;.
   </summary>
 </histogram>
 
-<histogram name="Previews.InfoBarAction.LitePage" enum="PreviewsInfoBarAction">
+<histogram name="Previews.InfoBarAction" enum="PreviewsInfoBarAction">
   <owner>bengr@chromium.org</owner>
   <owner>megjablon@chromium.org</owner>
   <summary>
-    User interactions with the previews LitePage &quot;Saved data&quot; infobar.
-    These include:
-
-    Displays of the infobar and clicks on the &quot;Load original&quot; link.
-    Whether the infobar was dismissed by navigation or the user clicking on
-    &quot;X&quot; close button.
-  </summary>
-</histogram>
-
-<histogram name="Previews.InfoBarAction.LoFi" enum="PreviewsInfoBarAction">
-  <owner>bengr@chromium.org</owner>
-  <owner>megjablon@chromium.org</owner>
-  <summary>
-    User interactions with the previews Lo-Fi &quot;Saved data&quot; infobar.
-    These include:
-
-    Displays of the infobar and clicks on the &quot;Load original&quot; link.
-    Whether the infobar was dismissed by navigation or the user clicking on
-    &quot;X&quot; close button.
-  </summary>
-</histogram>
-
-<histogram name="Previews.InfoBarAction.Offline" enum="PreviewsInfoBarAction">
-  <owner>bengr@chromium.org</owner>
-  <owner>megjablon@chromium.org</owner>
-  <summary>
-    User interactions with the previews Offline &quot;Faster page loaded&quot;
-    infobar. These include:
+    User interactions with the previews &quot;Saved data&quot; infobar. These
+    include:
 
     Displays of the infobar and clicks on the &quot;Load original&quot; link.
     Whether the infobar was dismissed by navigation or the user clicking on
@@ -55441,12 +55417,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
-<histogram name="Previews.OptOut.UserOptedOut.Offline"
-    enum="PreviewsUserOptedOut">
+<histogram name="Previews.OptOut.UserOptedOut" enum="PreviewsUserOptedOut">
   <owner>ryansturm@chromium.org</owner>
   <summary>
-    Whether the user chose to reload the full page when shown an offline
-    preview.
+    Whether the user chose to reload the original page when shown a preview.
   </summary>
 </histogram>
 
@@ -126047,9 +126021,14 @@ from previous Chrome versions.
 </histogram_suffixes>
 
 <histogram_suffixes name="Previews.Types" separator=".">
+  <affected-histogram name="Previews.EligibilityReason"/>

[tbansal1, 2017/05/02 21:49:31]

rm this line since it is already present below.

[RyanSturm, 2017/05/02 22:57:19]

Done.

   <suffix name="Offline" label="Offline previews"/>
   <suffix name="ClientLoFi" label="Client LoFi previews"/>
+  <suffix name="LitePage" label="Lite page previews"/>
+  <suffix name="ServerLoFi" label="Server LoFi previews"/>
   <affected-histogram name="Previews.EligibilityReason"/>
+  <affected-histogram name="Previews.InfoBarAction"/>

[tbansal1, 2017/05/02 21:49:31]

previews_infobar_delegate.cc already defines Previews.InfoBarAction.LoFi.
That sounds a bit same as Previews.InfoBarAction.ServerLoFi defined here.

[tbansal1, 2017/05/02 21:49:31]

Also, where is Previews.InfoBarAction.ClientLoFi populated?

[RyanSturm, 2017/05/02 22:57:19]

TBD. Since the work to actually expose Client LoFi just isn't done... I haven't
landed infobar yet. Complete CL here:
https://codereview.chromium.org/2848293002/

[RyanSturm, 2017/05/02 22:57:19]

Absolutely. This was a typo that is addressed throughout the CL now.

+  <affected-histogram name="Previews.OptOut.UserOptedOut"/>
 </histogram_suffixes>
 
 <histogram_suffixes name="ProcessType" separator=".">