Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Side by Side Diff: chrome/browser/previews/previews_service.cc

Issue 2760063002: Add support to previews/ for Server LoFi and LitePages (Closed)
Patch Set: rebase and previews_service_unittest.cc Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/previews/previews_service.h" 5 #include "chrome/browser/previews/previews_service.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
11 #include "base/threading/sequenced_worker_pool.h" 11 #include "base/threading/sequenced_worker_pool.h"
12 #include "chrome/common/chrome_constants.h" 12 #include "chrome/common/chrome_constants.h"
13 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_param s.h"
13 #include "components/previews/core/previews_experiments.h" 14 #include "components/previews/core/previews_experiments.h"
14 #include "components/previews/core/previews_io_data.h" 15 #include "components/previews/core/previews_io_data.h"
15 #include "components/previews/core/previews_opt_out_store.h" 16 #include "components/previews/core/previews_opt_out_store.h"
16 #include "components/previews/core/previews_opt_out_store_sql.h" 17 #include "components/previews/core/previews_opt_out_store_sql.h"
17 #include "components/previews/core/previews_ui_service.h" 18 #include "components/previews/core/previews_ui_service.h"
18 #include "content/public/browser/browser_thread.h" 19 #include "content/public/browser/browser_thread.h"
19 20
20 namespace { 21 namespace {
21 22
22 // Returns true if previews can be shown for |type|. 23 // Returns true if previews can be shown for |type|.
23 bool IsPreviewsTypeEnabled(previews::PreviewsType type) { 24 bool IsPreviewsTypeEnabled(previews::PreviewsType type) {
24 switch (type) { 25 switch (type) {
25 case previews::PreviewsType::OFFLINE: 26 case previews::PreviewsType::OFFLINE:
26 return previews::params::IsOfflinePreviewsEnabled(); 27 return previews::params::IsOfflinePreviewsEnabled();
27 case previews::PreviewsType::CLIENT_LOFI: 28 case previews::PreviewsType::CLIENT_LOFI:
28 return previews::params::IsClientLoFiEnabled(); 29 return previews::params::IsClientLoFiEnabled();
30 case previews::PreviewsType::SERVER_LOFI:
31 return data_reduction_proxy::params::IsLoFiOnViaFlags() ||
32 data_reduction_proxy::params::IsIncludedInLoFiEnabledFieldTrial();
33 case previews::PreviewsType::LITE_PAGE:
34 return (data_reduction_proxy::params::IsLoFiOnViaFlags() &&
35 data_reduction_proxy::params::AreLitePagesEnabledViaFlags()) ||
36 data_reduction_proxy::params::IsIncludedInLitePageFieldTrial();
37 // List remaining enum cases vs. default to catch when new one is added.
tbansal1 2017/05/02 21:49:30 nit: I do not think this comment is needed since i
RyanSturm 2017/05/02 22:57:18 Done.
29 case previews::PreviewsType::NONE: 38 case previews::PreviewsType::NONE:
30 case previews::PreviewsType::LAST: 39 case previews::PreviewsType::LAST:
31 break; 40 break;
32 } 41 }
33 NOTREACHED(); 42 NOTREACHED();
34 return false; 43 return false;
35 } 44 }
36 45
37 // Returns the version of preview treatment |type|. Defaults to 0 if not 46 // Returns the version of preview treatment |type|. Defaults to 0 if not
38 // specified in field trial config. 47 // specified in field trial config.
39 int GetPreviewsTypeVersion(previews::PreviewsType type) { 48 int GetPreviewsTypeVersion(previews::PreviewsType type) {
40 switch (type) { 49 switch (type) {
41 case previews::PreviewsType::OFFLINE: 50 case previews::PreviewsType::OFFLINE:
42 return previews::params::OfflinePreviewsVersion(); 51 return previews::params::OfflinePreviewsVersion();
43 case previews::PreviewsType::CLIENT_LOFI: 52 case previews::PreviewsType::CLIENT_LOFI:
44 return previews::params::ClientLoFiVersion(); 53 return previews::params::ClientLoFiVersion();
54 case previews::PreviewsType::LITE_PAGE:
55 return data_reduction_proxy::params::LitePageVersion();
56 case previews::PreviewsType::SERVER_LOFI:
57 return data_reduction_proxy::params::LoFiVersion();
58 // List remaining enum cases vs. default to catch when new one is added.
45 case previews::PreviewsType::NONE: 59 case previews::PreviewsType::NONE:
46 case previews::PreviewsType::LAST: 60 case previews::PreviewsType::LAST:
47 break; 61 break;
48 } 62 }
49 NOTREACHED(); 63 NOTREACHED();
50 return -1; 64 return -1;
51 } 65 }
52 66
53 // Returns the enabled PreviewsTypes with their version. 67 // Returns the enabled PreviewsTypes with their version.
54 std::unique_ptr<previews::PreviewsTypeList> GetEnabledPreviews() { 68 std::unique_ptr<previews::PreviewsTypeList> GetEnabledPreviews() {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 blocking_pool->GetSequencedTaskRunner(blocking_pool->GetSequenceToken()); 102 blocking_pool->GetSequencedTaskRunner(blocking_pool->GetSequenceToken());
89 103
90 previews_ui_service_ = base::MakeUnique<previews::PreviewsUIService>( 104 previews_ui_service_ = base::MakeUnique<previews::PreviewsUIService>(
91 previews_io_data, io_task_runner, 105 previews_io_data, io_task_runner,
92 base::MakeUnique<previews::PreviewsOptOutStoreSQL>( 106 base::MakeUnique<previews::PreviewsOptOutStoreSQL>(
93 io_task_runner, background_task_runner, 107 io_task_runner, background_task_runner,
94 profile_path.Append(chrome::kPreviewsOptOutDBFilename), 108 profile_path.Append(chrome::kPreviewsOptOutDBFilename),
95 GetEnabledPreviews()), 109 GetEnabledPreviews()),
96 base::Bind(&IsPreviewsTypeEnabled)); 110 base::Bind(&IsPreviewsTypeEnabled));
97 } 111 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698