Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Side by Side Diff: chrome/browser/previews/previews_service_unittest.cc

Issue 2760063002: Add support to previews/ for Server LoFi and LitePages (Closed)
Patch Set: comment fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/previews/previews_service.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/previews/previews_service.h"
6
7 #include <initializer_list>
8 #include <map>
9 #include <memory>
10 #include <string>
11
12 #include "base/files/file_path.h"
13 #include "base/memory/ptr_util.h"
14 #include "base/message_loop/message_loop.h"
15 #include "base/metrics/field_trial.h"
16 #include "base/metrics/field_trial_params.h"
17 #include "base/run_loop.h"
18 #include "base/single_thread_task_runner.h"
19 #include "components/previews/core/previews_io_data.h"
20 #include "components/previews/core/previews_ui_service.h"
21 #include "components/variations/variations_associated_data.h"
22 #include "content/public/browser/browser_thread.h"
23 #include "content/public/test/test_browser_thread_bundle.h"
24 #include "testing/gtest/include/gtest/gtest.h"
25
26 namespace {
27
28 void CreateFieldTrialWithParams(
29 const std::string& trial_name,
30 const std::string& group_name,
31 std::initializer_list<
32 typename std::map<std::string, std::string>::value_type> params) {
33 EXPECT_TRUE(base::AssociateFieldTrialParams(trial_name, group_name, params));
34 EXPECT_TRUE(base::FieldTrialList::CreateFieldTrial(trial_name, group_name));
35 }
36
37 // This test class intercepts the |is_enabled_callback| and is used to test its
38 // validity.
39 class TestPreviewsIOData : public previews::PreviewsIOData {
40 public:
41 TestPreviewsIOData()
42 : previews::PreviewsIOData(content::BrowserThread::GetTaskRunnerForThread(
43 content::BrowserThread::UI),
44 content::BrowserThread::GetTaskRunnerForThread(
45 content::BrowserThread::UI)) {}
46 ~TestPreviewsIOData() override {}
47
48 void Initialize(
49 base::WeakPtr<previews::PreviewsUIService> previews_ui_service,
50 std::unique_ptr<previews::PreviewsOptOutStore> previews_opt_out_store,
51 const previews::PreviewsIsEnabledCallback& is_enabled_callback) override {
52 enabled_callback_ = is_enabled_callback;
53 }
54
55 bool IsPreviewEnabled(previews::PreviewsType type) {
56 return enabled_callback_.Run(type);
57 }
58
59 private:
60 previews::PreviewsIsEnabledCallback enabled_callback_;
61 };
62
63 // Class to test the validity of the callback passed to PreviewsIOData from
64 // PreviewsService.
65 class PreviewsServiceTest : public testing::Test {
66 public:
67 PreviewsServiceTest()
68
69 : field_trial_list_(nullptr) {}
70
71 void SetUp() override {
72 io_data_ = base::MakeUnique<TestPreviewsIOData>();
73
74 service_ = base::MakeUnique<PreviewsService>();
75 base::FilePath file_path;
76 service_->Initialize(io_data_.get(),
77 content::BrowserThread::GetTaskRunnerForThread(
78 content::BrowserThread::UI),
79 file_path);
80 }
81
82 void TearDown() override { variations::testing::ClearAllVariationParams(); }
83
84 ~PreviewsServiceTest() override {}
85
86 TestPreviewsIOData* io_data() const { return io_data_.get(); }
87
88 private:
89 content::TestBrowserThreadBundle threads_;
90 base::FieldTrialList field_trial_list_;
91 std::unique_ptr<TestPreviewsIOData> io_data_;
92 std::unique_ptr<PreviewsService> service_;
93 };
94
95 } // namespace
96
97 TEST_F(PreviewsServiceTest, TestOfflineFieldTrialEnabled) {
98 CreateFieldTrialWithParams("ClientSidePreviews", "Enabled",
99 {{"show_offline_pages", "true"}});
100 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::OFFLINE));
101 }
102
103 TEST_F(PreviewsServiceTest, TestOfflineFieldTrialDisabled) {
104 CreateFieldTrialWithParams("ClientSidePreviews", "Disabled",
105 {{"show_offline_pages", "true"}});
106 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::OFFLINE));
107 }
108
109 TEST_F(PreviewsServiceTest, TestOfflineFieldTrialEnabledNotShowingOffline) {
110 CreateFieldTrialWithParams("ClientSidePreviews", "Disabled",
111 {{"show_offline_pages", "false"}});
112 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::OFFLINE));
113 }
114
115 TEST_F(PreviewsServiceTest, TestOfflineFieldTrialNotSet) {
116 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::OFFLINE));
117 }
118
119 TEST_F(PreviewsServiceTest, TestClientLoFiFieldTrialEnabled) {
120 base::FieldTrialList::CreateFieldTrial("PreviewsClientLoFi", "Enabled");
121 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI));
122 }
123
124 TEST_F(PreviewsServiceTest, TestClientLoFiFieldTrialDisabled) {
125 base::FieldTrialList::CreateFieldTrial("PreviewsClientLoFi", "Disabled");
126 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI));
127 }
128
129 TEST_F(PreviewsServiceTest, TestClientLoFiFieldTrialNotSet) {
130 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI));
131 }
132
133 TEST_F(PreviewsServiceTest, TestServerLoFiFieldTrialEnabled) {
134 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", "Enabled");
135 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI));
136 }
137
138 TEST_F(PreviewsServiceTest, TestServerLoFiFieldTrialDisabled) {
139 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi",
140 "Disabled");
141 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI));
142 }
143
144 TEST_F(PreviewsServiceTest, TestServerLoFiFieldTrialNotSet) {
145 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI));
146 }
147
148 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialEnabledPreview) {
149 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi",
150 "Enabled_Preview");
151 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE));
152 }
153
154 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialEnabled) {
155 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", "Enabled");
156 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE));
157 }
158
159 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialDisabled) {
160 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi",
161 "Disabled");
162 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE));
163 }
164
165 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialNotSet) {
166 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE));
167 }
OLDNEW
« no previous file with comments | « chrome/browser/previews/previews_service.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698