Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2760043002: Train ddc snapshot on itself (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
Reviewers:
jakemac
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Train ddc snapshot on itself This speeds up dartdevc on hello world from about 600ms to about 150ms. OTOH, it also increases the snapshot size from ~4.6M to ~31M (the latter is just under the size of the dart2js snapshot). I tried this before. This may break again on windows - if so, i'll revert. R=jakemac@google.com Committed: https://github.com/dart-lang/sdk/commit/1bd92d4f04f44aa00ce63345cd161d5fa773fab0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M utils/dartdevc/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 9 months ago (2017-03-20 17:50:45 UTC) #3
jakemac
lgtm
3 years, 9 months ago (2017-03-20 18:15:17 UTC) #4
vsm
3 years, 9 months ago (2017-03-21 01:51:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1bd92d4f04f44aa00ce63345cd161d5fa773fab0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698