third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js - Issue 2760013002: DevTools: Fixes regression in cookies tab in Network panel having no output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

Issue 2760013002: DevTools: Fixes regression in cookies tab in Network panel having no output (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

diff --git a/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js b/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

index 4bb51710c7e9f87027522c90879ab0ceb33de3a2..45b3271f84836d982278f3f725594273a7e59d51 100644

--- a/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

+++ b/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

@@ -165,6 +165,9 @@ CookieTable.CookiesTable = class extends UI.VBox {

* @return {?SDK.Cookie}

_findSelectedCookie(selectionCookies, cookies) {

+ if (!cookies)

eostroukhov 2017/03/20 17:34:59 Please fix JSDoc comment above to indicate that co

+ return null;

var current = selectionCookies.current;

var foundCurrent = cookies.find(cookie => this._isSameCookie(cookie, current));

if (foundCurrent)

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »