Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

Issue 2760013002: DevTools: Fixes regression in cookies tab in Network panel having no output (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * Copyright (C) 2010 Google Inc. All rights reserved. 4 * Copyright (C) 2010 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 willHide() { 158 willHide() {
159 this._lastEditedColumnId = null; 159 this._lastEditedColumnId = null;
160 } 160 }
161 161
162 /** 162 /**
163 * @param {{current: ?SDK.Cookie, neighbor: ?SDK.Cookie}} selectionCookies 163 * @param {{current: ?SDK.Cookie, neighbor: ?SDK.Cookie}} selectionCookies
164 * @param {!Array<!SDK.Cookie>} cookies 164 * @param {!Array<!SDK.Cookie>} cookies
165 * @return {?SDK.Cookie} 165 * @return {?SDK.Cookie}
166 */ 166 */
167 _findSelectedCookie(selectionCookies, cookies) { 167 _findSelectedCookie(selectionCookies, cookies) {
168 if (!cookies)
eostroukhov 2017/03/20 17:34:59 Please fix JSDoc comment above to indicate that co
169 return null;
170
168 var current = selectionCookies.current; 171 var current = selectionCookies.current;
169 var foundCurrent = cookies.find(cookie => this._isSameCookie(cookie, current )); 172 var foundCurrent = cookies.find(cookie => this._isSameCookie(cookie, current ));
170 if (foundCurrent) 173 if (foundCurrent)
171 return foundCurrent; 174 return foundCurrent;
172 175
173 var neighbor = selectionCookies.neighbor; 176 var neighbor = selectionCookies.neighbor;
174 var foundNeighbor = cookies.find(cookie => this._isSameCookie(cookie, neighb or)); 177 var foundNeighbor = cookies.find(cookie => this._isSameCookie(cookie, neighb or));
175 if (foundNeighbor) 178 if (foundNeighbor)
176 return foundNeighbor; 179 return foundNeighbor;
177 180
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 } 479 }
477 480
478 _refresh() { 481 _refresh() {
479 if (this._refreshCallback) 482 if (this._refreshCallback)
480 this._refreshCallback(); 483 this._refreshCallback();
481 } 484 }
482 }; 485 };
483 486
484 /** @const */ 487 /** @const */
485 CookieTable.CookiesTable._expiresSessionValue = Common.UIString('Session'); 488 CookieTable.CookiesTable._expiresSessionValue = Common.UIString('Session');
OLDNEW
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698