[Home] Use white doodle background when Chrome Home is enabled

chrome/browser/android/logo_service.cc

Index: chrome/browser/android/logo_service.cc
diff --git a/chrome/browser/android/logo_service.cc b/chrome/browser/android/logo_service.cc
index ae0796acc75123c4fe35e0c269b06b7c276fedf7..24cbd94ff069e9bc578d98fa6917fad1d3f5db9b 100644
--- a/chrome/browser/android/logo_service.cc
+++ b/chrome/browser/android/logo_service.cc
@@ -8,6 +8,7 @@
 #include "base/memory/weak_ptr.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "chrome/browser/android/chrome_feature_list.h"
 #include "chrome/browser/image_decoder.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
@@ -122,12 +123,14 @@ void LogoService::GetLogo(search_provider_logos::LogoObserver* observer) {
             new ChromeLogoDelegate())));
   }
 
+  bool gray_background =
+      !base::FeatureList::IsEnabled(chrome::android::kChromeHomeFeature);
   logo_tracker_->SetServerAPI(
       GetGoogleDoodleURL(profile_),
       base::Bind(&search_provider_logos::GoogleParseLogoResponse),
       base::Bind(&search_provider_logos::GoogleAppendQueryparamsToLogoURL),
       true, /* wants_cta */
-      true /* transparent */);
+      gray_background);

[justincohen, 2017/03/20 17:16:30]

Please update ios/chrome/browser/google/google_logo_service.mm to replace /*
transparent */.

I'm confused about what this param actually does.  Is the doodle grey or
transparent?  If it's grey, do we have documented what the color code is
actually used by the doodle team (e.g.# 808080) ?

[Theresa, 2017/03/20 17:29:52]

Done.
It's gray. Per comment #9 on the bug, it used to be transparent but that doesn't
work well with animations where artists prefer a background color to avoid
artifacts. It sounds like the server is being updated (or was updated recently)
so that only the graybg:1 parameter (and not transp:1 paramater) is needed.

The gray being used should be #f2f2f2 to match our NTP background color. I
updated the documentation in logo_tracker.h to explicitly mention the gray
matching the NTP background color. I'm hesitant to document the specific hex
color since it may get out-of-sync with what our NTP is displaying and the
server is returning.

   logo_tracker_->GetLogo(observer);
 }