Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: runtime/observatory/tests/service/get_stack_rpc_test.dart

Issue 2759973004: Fix observatory tests broken by running dartfmt. Temporarily reverted formatting for evaluate_activ… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/get_stack_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_stack_rpc_test.dart b/runtime/observatory/tests/service/get_stack_rpc_test.dart
index ff6cac382db831f445ccf98de1ea9b6ce08f9da9..4840e76282e5d22755a2b9c914f4660964ed84e7 100644
--- a/runtime/observatory/tests/service/get_stack_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_stack_rpc_test.dart
@@ -17,7 +17,7 @@ const stoppedAtLine = 25;
var port = new isolate.RawReceivePort(msgHandler);
// This name is used in a test below.
-void msgHandler(_) { }
+void msgHandler(_) {}
void periodicTask(_) {
port.sendPort.send(34);
@@ -29,67 +29,65 @@ void periodicTask(_) {
}
void startTimer() {
- new Timer.periodic(const Duration(milliseconds:10), periodicTask);
+ new Timer.periodic(const Duration(milliseconds: 10), periodicTask);
}
var tests = [
-
// Initial data fetch and verify we've hit the breakpoint.
-(Isolate isolate) async {
- await isolate.rootLibrary.load();
- var script = isolate.rootLibrary.scripts[0];
- await script.load();
- await hasStoppedAtBreakpoint(isolate);
- // Sanity check.
- expect(isolate.pauseEvent is M.PauseBreakpointEvent, isTrue);
-},
+ (Isolate isolate) async {
+ await isolate.rootLibrary.load();
+ var script = isolate.rootLibrary.scripts[0];
+ await script.load();
+ await hasStoppedAtBreakpoint(isolate);
+ // Sanity check.
+ expect(isolate.pauseEvent is M.PauseBreakpointEvent, isTrue);
+ },
// Get stack
-(Isolate isolate) async {
- var stack = await isolate.getStack();
- expect(stack.type, equals('Stack'));
+ (Isolate isolate) async {
+ var stack = await isolate.getStack();
+ expect(stack.type, equals('Stack'));
- // Sanity check.
- expect(stack['frames'].length, greaterThanOrEqualTo(1));
- Script script = stack['frames'][0].location.script;
- expect(script.tokenToLine(stack['frames'][0].location.tokenPos),
- equals(stoppedAtLine));
+ // Sanity check.
+ expect(stack['frames'].length, greaterThanOrEqualTo(1));
+ Script script = stack['frames'][0].location.script;
+ expect(script.tokenToLine(stack['frames'][0].location.tokenPos),
+ equals(stoppedAtLine));
- // Iterate over frames.
- var frameDepth = 0;
- for (var frame in stack['frames']) {
- print('checking frame $frameDepth');
- expect(frame.type, equals('Frame'));
- expect(frame.index, equals(frameDepth++));
- expect(frame.code.type, equals('Code'));
- expect(frame.function.type, equals('Function'));
- expect(frame.location.type, equals('SourceLocation'));
- }
+ // Iterate over frames.
+ var frameDepth = 0;
+ for (var frame in stack['frames']) {
+ print('checking frame $frameDepth');
+ expect(frame.type, equals('Frame'));
+ expect(frame.index, equals(frameDepth++));
+ expect(frame.code.type, equals('Code'));
+ expect(frame.function.type, equals('Function'));
+ expect(frame.location.type, equals('SourceLocation'));
+ }
- // Sanity check.
- expect(stack['messages'].length, greaterThanOrEqualTo(1));
+ // Sanity check.
+ expect(stack['messages'].length, greaterThanOrEqualTo(1));
- // Iterate over messages.
- var messageDepth = 0;
- // objectId of message to be handled by msgHandler.
- var msgHandlerObjectId;
- for (var message in stack['messages']) {
- print('checking message $messageDepth');
- expect(message.index, equals(messageDepth++));
- expect(message.size, greaterThanOrEqualTo(0));
- expect(message.handler.type, equals('Function'));
- expect(message.location.type, equals('SourceLocation'));
- if (message.handler.name.contains('msgHandler')) {
- msgHandlerObjectId = message.messageObjectId;
+ // Iterate over messages.
+ var messageDepth = 0;
+ // objectId of message to be handled by msgHandler.
+ var msgHandlerObjectId;
+ for (var message in stack['messages']) {
+ print('checking message $messageDepth');
+ expect(message.index, equals(messageDepth++));
+ expect(message.size, greaterThanOrEqualTo(0));
+ expect(message.handler.type, equals('Function'));
+ expect(message.location.type, equals('SourceLocation'));
+ if (message.handler.name.contains('msgHandler')) {
+ msgHandlerObjectId = message.messageObjectId;
+ }
}
- }
- expect(msgHandlerObjectId, isNotNull);
-
- // Get object.
- var object = await isolate.getObject(msgHandlerObjectId);
- expect(object.valueAsString, equals('34'));
-}
+ expect(msgHandlerObjectId, isNotNull);
+ // Get object.
+ var object = await isolate.getObject(msgHandlerObjectId);
+ expect(object.valueAsString, equals('34'));
+ }
];
main(args) => runIsolateTests(args, tests, testeeBefore: startTimer);

Powered by Google App Engine
This is Rietveld 408576698