Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2653)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 27599002: A page should exit fullscreen mode if it opens a new popup (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index dce10f4deaafdaf62638d57c9fdb8a7c6c8052b2..d3bc556ed66b6c71b8a1581e935903de8c412436 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -71,6 +71,7 @@
#include "core/accessibility/AXObjectCache.h"
#include "core/accessibility/AccessibilityObject.h"
#include "core/dom/Document.h"
+#include "core/dom/DocumentFullscreen.h"
#include "core/dom/Node.h"
#include "core/html/HTMLInputElement.h"
#include "core/loader/DocumentLoader.h"
@@ -238,6 +239,8 @@ Page* ChromeClientImpl::createWindow(
if (policy == WebNavigationPolicyIgnore)
policy = getNavigationPolicy();
+ DocumentFullscreen::webkitCancelFullScreen(frame->document());
+
WebViewImpl* newView = toWebViewImpl(
m_webView->client()->createView(WebFrameImpl::fromFrame(frame), WrappedResourceRequest(r.resourceRequest()), features, r.frameName(), policy));
if (!newView)
« no previous file with comments | « LayoutTests/fullscreen/full-screen-exit-when-popup-expected.txt ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698