Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListItem.cpp

Issue 2759883002: Get markers back while list items have overflow:hidden children (Closed)
Patch Set: omit addLogicalHeightFromChild() Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/lists/list-marker-before-overflow-hidden-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutListItem.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
index 6c989742027127c6dc1661a27923892756f73f93..4dbf2a750c28fff5f640778b6f83743269503373 100644
--- a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
@@ -257,6 +257,11 @@ static LayoutObject* getParentOfFirstLineBox(LayoutBlockFlow* curr,
if (currChild == marker)
continue;
+ // Shouldn't add marker into Overflow box, instead, add marker
+ // into listitem
+ if (currChild->hasOverflowClip())
+ break;
+
if (currChild->isInline() &&
(!currChild->isLayoutInline() ||
curr->generatesLineBoxesForInlineChild(currChild)))
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/lists/list-marker-before-overflow-hidden-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698