Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1786)

Unified Diff: chrome/browser/installable/installable_manager.cc

Issue 2759753002: Fetch manifest icon prior to checking eligibility in InstallableManager (Closed)
Patch Set: Fetch manifest icon prior to checking eligibility in InstallableManager Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/installable/installable_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/installable/installable_manager.cc
diff --git a/chrome/browser/installable/installable_manager.cc b/chrome/browser/installable/installable_manager.cc
index 1b9b10b3004bf11e970295a338066ea447db2c0f..765a7f47e5c3ebdbedee29489a8e074a96930120 100644
--- a/chrome/browser/installable/installable_manager.cc
+++ b/chrome/browser/installable/installable_manager.cc
@@ -373,11 +373,11 @@ void InstallableManager::WorkOnTask() {
if (!manifest_->fetched) {
FetchManifest();
- } else if (params.check_installable && !installable_->fetched) {
- CheckInstallable();
} else if (params.fetch_valid_primary_icon &&
!IsIconFetched(ParamsForPrimaryIcon(params))) {
CheckAndFetchBestIcon(ParamsForPrimaryIcon(params));
+ } else if (params.check_installable && !installable_->fetched) {
+ CheckInstallable();
} else if (params.fetch_valid_badge_icon &&
!IsIconFetched(ParamsForBadgeIcon(params))) {
CheckAndFetchBestIcon(ParamsForBadgeIcon(params));
« no previous file with comments | « no previous file | chrome/browser/installable/installable_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698