Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4259)

Unified Diff: chrome/browser/installable/installable_manager.cc

Issue 2759753002: Fetch manifest icon prior to checking eligibility in InstallableManager (Closed)
Patch Set: Add tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_manager.cc
diff --git a/chrome/browser/installable/installable_manager.cc b/chrome/browser/installable/installable_manager.cc
index b0bf4496513b77bdd42977cfe2e53435a498d2dc..927941965b6eb4e61f8ef892e71611b5d1619200 100644
--- a/chrome/browser/installable/installable_manager.cc
+++ b/chrome/browser/installable/installable_manager.cc
@@ -301,11 +301,11 @@ void InstallableManager::WorkOnTask() {
if (!manifest_->fetched) {
FetchManifest();
- } else if (params.check_installable && !installable_->fetched) {
- CheckInstallable();
} else if (params.fetch_valid_primary_icon &&
!IsIconFetched(ParamsForPrimaryIcon(params))) {
CheckAndFetchBestIcon(ParamsForPrimaryIcon(params));
+ } else if (params.check_installable && !installable_->fetched) {
+ CheckInstallable();
} else if (params.fetch_valid_badge_icon &&
!IsIconFetched(ParamsForBadgeIcon(params))) {
CheckAndFetchBestIcon(ParamsForBadgeIcon(params));

Powered by Google App Engine
This is Rietveld 408576698