Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: components/navigation_interception/navigation_params.cc

Issue 2759723002: Update the assignment operator (Closed)
Patch Set: fix compile fail Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/navigation_interception/navigation_params.cc
diff --git a/components/navigation_interception/navigation_params.cc b/components/navigation_interception/navigation_params.cc
index fb66ba6e4d782deede59334966f048a2eb06932c..fe654e6d556dd0c128175ae6ce4f018de7371188 100644
--- a/components/navigation_interception/navigation_params.cc
+++ b/components/navigation_interception/navigation_params.cc
@@ -6,10 +6,6 @@
namespace navigation_interception {
-NavigationParams::NavigationParams(const NavigationParams& other) {
- Assign(other);
-}
-
NavigationParams::NavigationParams(const GURL& url,
const content::Referrer& referrer,
bool has_user_gesture,
@@ -29,20 +25,7 @@ NavigationParams::NavigationParams(const GURL& url,
is_main_frame_(is_main_frame),
base_url_for_data_url_(base_url_for_data_url) {}
-void NavigationParams::operator=(const NavigationParams& rhs) {
- Assign(rhs);
-}
-
-void NavigationParams::Assign(const NavigationParams& other) {
- url_ = other.url();
- referrer_ = other.referrer();
- has_user_gesture_ = other.has_user_gesture();
- is_post_ = other.is_post();
- transition_type_ = other.transition_type();
- is_redirect_ = other.is_redirect();
- is_external_protocol_ = other.is_external_protocol();
- is_main_frame_ = other.is_main_frame();
-}
+NavigationParams::NavigationParams(const NavigationParams&) = default;
} // namespace navigation_interception

Powered by Google App Engine
This is Rietveld 408576698