Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: components/navigation_interception/navigation_params.h

Issue 2759723002: Update the assignment operator (Closed)
Patch Set: Address jam review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/navigation_interception/navigation_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/navigation_interception/navigation_params.h
diff --git a/components/navigation_interception/navigation_params.h b/components/navigation_interception/navigation_params.h
index c42637b22e3e7ac03d7a098b3b60baa5cea9678e..07070a2f81a02163ed0566fe7b6b4a01d3fddcaf 100644
--- a/components/navigation_interception/navigation_params.h
+++ b/components/navigation_interception/navigation_params.h
@@ -23,8 +23,8 @@ class NavigationParams {
bool is_external_protocol,
bool is_main_frame,
const GURL& base_url_for_data_url);
- NavigationParams(const NavigationParams& other);
- void operator=(const NavigationParams& rhs);
+ NavigationParams(const NavigationParams&) = default;
+ NavigationParams& operator=(const NavigationParams&) = default;
jam1 2017/03/17 19:59:39 nit: i think this isn't actually used
const GURL& url() const { return url_; }
GURL& url() { return url_; }
@@ -38,7 +38,6 @@ class NavigationParams {
const GURL& base_url_for_data_url() const { return base_url_for_data_url_; }
private:
- void Assign(const NavigationParams& other);
GURL url_;
content::Referrer referrer_;
« no previous file with comments | « no previous file | components/navigation_interception/navigation_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698