Update the assignment operator

components/navigation_interception/navigation_params.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/navigation_interception/navigation_params.h"
 
 namespace navigation_interception {
 
 NavigationParams::NavigationParams(const NavigationParams& other) {
   Assign(other);
@@ skipping 15 matching lines @@
       transition_type_(transition_type),
       is_redirect_(is_redirect),
       is_external_protocol_(is_external_protocol),
       is_main_frame_(is_main_frame),
       base_url_for_data_url_(base_url_for_data_url) {}
 
 void NavigationParams::operator=(const NavigationParams& rhs) {
   Assign(rhs);
 }
 
 void NavigationParams::Assign(const NavigationParams& other) {

[jam, 2017/03/17 19:16:23]

can you just get rid of this method and the manually defined assignment
operator, and instead use the default one? i.e. in the header:

NavigationParams(const NavigationParams& other) = default;

[sgurun-gerrit only, 2017/03/17 19:56:51]

that removes a lot of boilerplate.

   url_ = other.url();
   referrer_ = other.referrer();
   has_user_gesture_ = other.has_user_gesture();
   is_post_ = other.is_post();
   transition_type_ = other.transition_type();
   is_redirect_ = other.is_redirect();
   is_external_protocol_ = other.is_external_protocol();
   is_main_frame_ = other.is_main_frame();
+  base_url_for_data_url_ = other.base_url_for_data_url();
 }
 
 }  // namespace navigation_interception