third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp - Issue 2759703002: Migrate WTF::HashMap::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp

Issue 2759703002: Migrate WTF::HashMap::remove() to ::erase() (Closed)

Patch Set: rebase, fix one platform-specific reference Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp

diff --git a/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp b/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp

index f83b8568f2e4b9eba66e673ab061895049408554..9c2f6d85661d02c2b5411e27c088e262bdb6af45 100644

--- a/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp

+++ b/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp

@@ -102,7 +102,7 @@ void DocumentOrderedMap::remove(const AtomicString& key, Element* element) {

DCHECK(entry->count);

if (entry->count == 1) {

DCHECK(!entry->element || entry->element == element);

- m_map.remove(it);

+ m_map.erase(it);

} else {

if (entry->element == element) {

DCHECK(entry->orderedList.isEmpty() ||