Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2759683002: Updating android_aar_prebuilt rule to prevent unneeded args if the res folder is empty.

Created:
3 years, 9 months ago by mmcmahon
Modified:
3 years, 9 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating android_aar_prebuilt rule to prevent unneeded args if the res folder is empty. If archive res folder exists but is empty, android_aar_prebuilt should not ad the 'generated_resource_dirs' and 'generated_resource_files' args. This is an issue if an aar has both a R.txt file and and empty res folder. In that case the generated __res.build_config file will have a 'resources_dirs' arg for a folder that does not exist. BUG=702606 R=agrieve@chromium.org TEST=See crbug.com/702606 for steps to repro

Patch Set 1 #

Patch Set 2 : Adding name to AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mmcmahon
3 years, 9 months ago (2017-03-17 14:37:49 UTC) #1
agrieve
On 2017/03/17 14:37:49, mmcmahon wrote: lgtm, but commit first line is a bit wonky: "rule ...
3 years, 9 months ago (2017-03-17 14:41:36 UTC) #2
mmcmahon
Fixed up the commit description
3 years, 9 months ago (2017-03-17 14:50:51 UTC) #5
mmcmahon
3 years, 9 months ago (2017-03-20 17:54:33 UTC) #6

          

Powered by Google App Engine
This is Rietveld 408576698