Improve parsing of async and generator methods.

Improve parsing of async and generator methods.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/8979b040ec731f1c5aca682c12159ed79e2917a9

[ahe, 2017-03-17 13:17:14]

Patchset #1 (id:1) has been deleted

[ahe, 2017-03-17 13:17:24]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-03-17 13:34:10]

lgtm

https://codereview.chromium.org/2759663002/diff/20001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/element_listener.dart (right):

https://codereview.chromium.org/2759663002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/element_listener.dart:785: "text": "'yield' can only
be used 'sync*' or 'async*' methods."
used 'sync*' -> used in 'sync*'

https://codereview.chromium.org/2759663002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/element_listener.dart:813: "'async', 'async*', or
'sync*' methods."
'yield' -> 'await'

https://codereview.chromium.org/2759663002/diff/20001/tests/language/language...
File tests/language/language_kernel.status (right):

https://codereview.chromium.org/2759663002/diff/20001/tests/language/language...
tests/language/language_kernel.status:655: regress_22445_test: Crash
Why are these now crashing?

[ahe, 2017-03-17 14:00:16]

Thank you, Johnni!

https://codereview.chromium.org/2759663002/diff/20001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/element_listener.dart (right):

https://codereview.chromium.org/2759663002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/element_listener.dart:785: "text": "'yield' can only
be used 'sync*' or 'async*' methods."
On 2017/03/17 13:34:10, Johnni Winther wrote:
> used 'sync*' -> used in 'sync*'

Done.

https://codereview.chromium.org/2759663002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/element_listener.dart:813: "'async', 'async*', or
'sync*' methods."
On 2017/03/17 13:34:10, Johnni Winther wrote:
> 'yield' -> 'await'

Done.

https://codereview.chromium.org/2759663002/diff/20001/tests/language/language...
File tests/language/language_kernel.status (right):

https://codereview.chromium.org/2759663002/diff/20001/tests/language/language...
tests/language/language_kernel.status:655: regress_22445_test: Crash
On 2017/03/17 13:34:10, Johnni Winther wrote:
> Why are these now crashing?

Because I ran a configuration that's rarely tested. It ran all night but didn't
complete :-O

[ahe, 2017-03-17 17:03:49]

Description was changed from

==========
Improve parsing of async and generator methods.
==========

to

==========
Improve parsing of async and generator methods.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8979b040ec731f1c5aca682c12159ed79e2917a9
==========

[ahe, 2017-03-17 17:03:50]

Committed patchset #3 (id:60001) manually as
8979b040ec731f1c5aca682c12159ed79e2917a9 (presubmit successful).