Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: ash/mus/window_manager.cc

Issue 2759643003: Add system modals to the proper container in mus+ash. (Closed)
Patch Set: addressed feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/window_manager.h ('k') | mash/simple_wm/simple_wm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/window_manager.cc
diff --git a/ash/mus/window_manager.cc b/ash/mus/window_manager.cc
index 3476cc5f50d21775db6d12b1fa4bf715074796a2..fdfe7605cf06f5ed5b0232acbeba2eb40c1c2a07 100644
--- a/ash/mus/window_manager.cc
+++ b/ash/mus/window_manager.cc
@@ -38,6 +38,7 @@
#include "services/ui/public/cpp/property_type_converters.h"
#include "services/ui/public/interfaces/constants.mojom.h"
#include "services/ui/public/interfaces/window_manager.mojom.h"
+#include "ui/aura/client/aura_constants.h"
#include "ui/aura/client/window_parenting_client.h"
#include "ui/aura/env.h"
#include "ui/aura/mus/capture_synchronizer.h"
@@ -323,6 +324,23 @@ bool WindowManager::OnWmSetProperty(
return false;
}
+void WindowManager::OnWmSetModalType(aura::Window* window, ui::ModalType type) {
+ ui::ModalType old_type = window->GetProperty(aura::client::kModalKey);
+ if (type == old_type)
+ return;
+
+ window->SetProperty(aura::client::kModalKey, type);
+ if (type != ui::MODAL_TYPE_SYSTEM && old_type != ui::MODAL_TYPE_SYSTEM)
+ return;
+
+ WmWindow* new_parent =
+ wm::GetDefaultParent(WmWindow::Get(window), window->bounds());
+ DCHECK(new_parent);
+ if (window->parent())
+ window->parent()->RemoveChild(window);
+ new_parent->aura_window()->AddChild(window);
+}
+
void WindowManager::OnWmSetCanFocus(aura::Window* window, bool can_focus) {
NonClientFrameController* non_client_frame_controller =
NonClientFrameController::Get(window);
« no previous file with comments | « ash/mus/window_manager.h ('k') | mash/simple_wm/simple_wm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698