Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2759623003: Track async state in parser. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -36 lines) Patch
M pkg/analyzer/lib/src/summary/fasta/summary_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 4 chunks +17 lines, -7 lines 0 comments Download
A pkg/front_end/lib/src/fasta/parser/async_modifier.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/class_member_parser.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 13 chunks +36 lines, -19 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/top_level_parser.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_parser.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
In the next CL, I'll start using this state to report errors when, for example, ...
3 years, 9 months ago (2017-03-17 11:46:29 UTC) #2
Johnni Winther
lgtm
3 years, 9 months ago (2017-03-17 11:50:25 UTC) #3
ahe
3 years, 9 months ago (2017-03-17 13:43:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
323d5b0b7f70bce4ece9e255c79b627d38bb2cd3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698