mojo/public/tools/bindings/mojom_bindings_generator.py - Issue 2759563004: Mojo JS bindings: change module loading solution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/mojom_bindings_generator.py

Issue 2759563004: Mojo JS bindings: change module loading solution. (Closed)

Patch Set: Make sure mojo_bindings.js is packaged in build result for running layout tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/mojom_bindings_generator.py

diff --git a/mojo/public/tools/bindings/mojom_bindings_generator.py b/mojo/public/tools/bindings/mojom_bindings_generator.py

index 3a0b6fc87e25f23febb0e6ff049728f6013fcb42..a9650d77640776f4fa9e0814236fee5b22a7e98b 100755

--- a/mojo/public/tools/bindings/mojom_bindings_generator.py

+++ b/mojo/public/tools/bindings/mojom_bindings_generator.py

@@ -167,6 +167,7 @@ class MojomProcessor(object):

variant=args.variant, bytecode_path=args.bytecode_path,

for_blink=args.for_blink,

use_once_callback=args.use_once_callback,

+ use_new_js_bindings=args.use_new_js_bindings,

export_attribute=args.export_attribute,

export_header=args.export_header,

generate_non_variant_code=args.generate_non_variant_code)

@@ -298,6 +299,10 @@ def main():

"--use_once_callback", action="store_true",

help="Use base::OnceCallback instead of base::RepeatingCallback.")

generate_parser.add_argument(

+ "--use_new_js_bindings", action="store_true",

+ help="Use the new module loading approach and the core API exposed by "

+ "Web IDL. This option only affects the JavaScript bindings.")

+ generate_parser.add_argument(

"--export_attribute", type=str, default="",

help="Optional attribute to specify on class declaration to export it "

"for the component build.")