mojo/public/interfaces/bindings/tests/echo_service.mojom - Issue 2759563004: Mojo JS bindings: change module loading solution.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/interfaces/bindings/tests/echo_service.mojom

Issue 2759563004: Mojo JS bindings: change module loading solution. (Closed)

Patch Set: add test module-loading.html Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mojo.test.echo;

	6

	7 import "echo_import.mojom";

	8

	9 interface EchoService {
	Ken Rockot(use gerrit already) 2017/03/20 15:27:20 nit: Even in spite of other "service" names in tes nit: Even in spite of other "service" names in test interfaces, would you mind changing this to not be "EchoService"? Could it just be "Echo"? And could we add an inner mojom namespace? yzshen1 2017/03/20 17:45:02 Done. Thanks! Show quoted text On 2017/03/20 15:27:20, Ken Rockot wrote: > nit: Even in spite of other "service" names in test interfaces, would you mind > changing this to not be "EchoService"? Could it just be "Echo"? And could we add > an inner mojom namespace? Done. Thanks!
	10 EchoPoint(mojo.test.echo_import.Point point)

	11 => (mojo.test.echo_import.Point result);

	12 };

OLD	NEW