Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: tools/gardening/bin/create_shard_groups.dart

Issue 2759533003: Fixed bug: last entry was missing from shard_data.dart (Closed)
Patch Set: Added script tag to shard2group.dart Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gardening/bin/shard2group.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/bin/create_shard_groups.dart
diff --git a/tools/gardening/bin/create_shard_groups.dart b/tools/gardening/bin/create_shard_groups.dart
index b54a87765d9bbee658cd2f64bb81426214729daf..e513e5f958e43d8663ea180f10af0f2ee567fa10 100644
--- a/tools/gardening/bin/create_shard_groups.dart
+++ b/tools/gardening/bin/create_shard_groups.dart
@@ -41,7 +41,10 @@ List<List<String>> findShards(List<String> source) {
for (String line in source) {
if (line.contains(shardsStartMark)) started = true;
if (started) {
- if (line.contains(shardsEndMark)) break;
+ if (line.contains(shardsEndMark)) {
+ if (shardResult != null) result.add(shardResult);
+ break;
+ }
String trimmed = line.trim();
int buildersIndex = trimmed.indexOf(shardMark);
if (buildersIndex >= 0) {
« no previous file with comments | « no previous file | tools/gardening/bin/shard2group.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698