Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2759533003: Fixed bug: last entry was missing from shard_data.dart (Closed)

Created:
3 years, 9 months ago by eernst
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed bug: last entry was missing from shard_data.dart R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/eb01590af4efb42d8a89bad42e82c61ecb8f5805

Patch Set 1 #

Patch Set 2 : Added script tag to shard2group.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M tools/gardening/bin/create_shard_groups.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tools/gardening/bin/shard2group.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gardening/lib/src/shard_data.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eernst
A small bug fix in the shard2group.dart gardening script: Last group was omitted.
3 years, 9 months ago (2017-03-17 15:59:40 UTC) #2
floitsch
LGTM.
3 years, 9 months ago (2017-03-17 16:36:20 UTC) #4
eernst
3 years, 9 months ago (2017-03-17 16:44:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eb01590af4efb42d8a89bad42e82c61ecb8f5805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698