Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 275943003: Enable higher latency audio on Windows for basic playback. (Closed)

Created:
6 years, 7 months ago by DaleCurtis
Modified:
6 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable higher latency audio on Windows for basic playback. This does not change the WASAPI callback frequency, just the amount of data that gets buffered on the browser side. Sadly the WASAPI callback frequency is fixed irrespective of the buffer size we specify, so the best we can do is reduce the number of IPC round trips. The net effect of this change is that the renderer side sends larger chunks to the browser which are FIFO'd by AudioOutputResampler to the output buffer size desired by WASAPI. Having more data on the browser side should help reduce glitching when the system is under load. With this change all platforms have a high latency buffer size implementation, so some #define gunk can be removed too. BUG=362261, 362294 TEST=FIFO is created on the browser side. Audio sounds fine. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270519

Patch Set 1 : No^2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -21 lines) Patch
M media/base/audio_hardware_config.cc View 4 chunks +19 lines, -15 lines 0 comments Download
M media/base/audio_hardware_config_unittest.cc View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
DaleCurtis
6 years, 7 months ago (2014-05-13 22:50:30 UTC) #1
henrika (OOO until Aug 14)
Looks good Dale. I think it will work well but do you plan to follow ...
6 years, 7 months ago (2014-05-14 10:45:33 UTC) #2
DaleCurtis
Fixed the title to remove "lower power." Thanks for review!
6 years, 7 months ago (2014-05-14 17:27:25 UTC) #3
DaleCurtis
Oh, and yes, I will do some measurements on my home machine to see if ...
6 years, 7 months ago (2014-05-14 17:27:45 UTC) #4
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-05-14 17:27:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/275943003/60001
6 years, 7 months ago (2014-05-14 17:28:28 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 20:18:21 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 20:21:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/151931)
6 years, 7 months ago (2014-05-14 20:21:48 UTC) #9
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-05-14 23:05:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/275943003/60001
6 years, 7 months ago (2014-05-14 23:07:23 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 00:02:02 UTC) #12
Message was sent while issue was closed.
Change committed as 270519

Powered by Google App Engine
This is Rietveld 408576698