Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2759393005: Cleanup change. (Closed)

Created:
3 years, 9 months ago by regis
Modified:
3 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup change. AssertAssignableInstr::Canonicalize was too restrictive: it can instantiate the type even if the instantiator is null. Do not allocate empty TypeArguments handles, but use the common one instead. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/bde22d2dee87eebd1b7cb4afc3280777b5868aef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M runtime/vm/aot_optimizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 9 months ago (2017-03-21 20:49:17 UTC) #2
Florian Schneider
Lgtm
3 years, 9 months ago (2017-03-21 20:52:41 UTC) #3
regis
3 years, 9 months ago (2017-03-21 20:55:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bde22d2dee87eebd1b7cb4afc3280777b5868aef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698