third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl - Issue 2759343002: Generate inherited nonproperties insideLink and hasSimpleUnderline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

Issue 2759343002: Generate inherited nonproperties insideLink and hasSimpleUnderline. (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

index 2f1fc578035e3504e31aaadef5564a9349624082..5e738d20ec2931d012b750a30d38bf1222e2c2d0 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

@@ -16,7 +16,7 @@ ASSERT_SIZE(ComputedStyleBase, SameSizeAsComputedStyleBase);

void ComputedStyleBase::inheritFrom(const ComputedStyleBase& inheritParent,

IsAtShadowBoundary isAtShadowBoundary) {

- {% for field in fields if field.is_property and field.is_inherited %}

alancutter (OOO until 2018) 2017/03/22 06:25:19 Good to see is_property checks being removed. Woul

shend 2017/03/22 22:02:00 It is unlikely we'll be able to remove is_property

+ {% for field in fields if field.is_inherited %}

{{field.name}} = inheritParent.{{field.name}};

{% endfor %}

}