Generate inherited nonproperties insideLink and hasSimpleUnderline.

third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

 {% from 'macros.tmpl' import license %}
 {{license()}}
 
 #include "core/ComputedStyleBase.h"
 #include "wtf/SizeAssertions.h"
 
 namespace blink {
 
 struct SameSizeAsComputedStyleBase {
   unsigned m_bitfields[{{expected_total_field_bytes}}];
 };
 // If this fails, the packing algorithm in make_computed_style_base.py has
 // failed to produce the optimal packed size. To fix, update the algorithm to
 // ensure that the buckets are placed so that each takes up at most 1 word.
 ASSERT_SIZE(ComputedStyleBase, SameSizeAsComputedStyleBase);
 
 void ComputedStyleBase::inheritFrom(const ComputedStyleBase& inheritParent,
                                     IsAtShadowBoundary isAtShadowBoundary) {
-  {% for field in fields if field.is_property and field.is_inherited %}

[alancutter (OOO until 2018), 2017/03/22 06:25:19]

Good to see is_property checks being removed. Would it make sense to add a TODO
to remove is_property from Field entirely?

[shend, 2017/03/22 22:02:00]

It is unlikely we'll be able to remove is_property entirely, since there are
still behaviour differences between properties and nonproperties (e.g.
copyNonInheritedFromCached).

+  {% for field in fields if field.is_inherited %}
   {{field.name}} = inheritParent.{{field.name}};
   {% endfor %}
 }
 
 void ComputedStyleBase::copyNonInheritedFromCached(

[alancutter (OOO until 2018), 2017/03/22 06:25:19]

Unrelated to this patch: This method might be simpler if it were just
copyNonInherited() and didn't care about whether the parameter is a cache or
not. The cache logic should exist at the call site and then this may be able to
be reused in the copy constructor etc. A similar thing may be done with
inheritFrom() (renamed as copyInherited() for consistency).

Just random ideas, feel free to disregard if it doesn't work out. 

     const ComputedStyleBase& other) {
   {% for field in fields if (field.is_property and not field.is_inherited) or field.is_inherited_flag %}
   {{field.name}} = other.{{field.name}};
   {% endfor %}
 }
 
 void ComputedStyleBase::propagateIndependentInheritedProperties(
     const ComputedStyleBase& parentStyle) {
   {% for field in fields if field.is_property and field.is_independent %}
   if ({{field.is_inherited_method_name}}())
     {{field.setter_method_name}}(parentStyle.{{field.getter_method_name}}());
   {% endfor %}
 }
 
 } // namespace blink