Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2759333004: Fix spew when running presubmit which triggers dartfmt.bat on windows. We should also backport this… (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 8 months ago
Reviewers:
Bob Nystrom, Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix spew when running presubmit which triggers dartfmt.bat on windows. We should also backport this change to the sdks in tools/sdk or roll a new version of the tools/sdk Error span you otherwise get with each dartfmt invocation: find: ‘> bin [’: No such file or directory Note that the error doesn't occur all times dartfmt is run, only when it is run from the directory triggered by the presubmit. BUG= R=rnystrom@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/b5d53b5348cf8aad8a63b6414374bc07584b03a3

Patch Set 1 #

Patch Set 2 : Fix spew when running presubmit which triggers dartfmt.bat on windows. We should also backport this… #

Patch Set 3 : Fix spew when running presubmit which triggers dartfmt.bat on windows. We should also backport this… #

Patch Set 4 : Fix spew when running presubmit which triggers dartfmt.bat on windows. We should also backport this… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M sdk/bin/dart2js.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart2js_sdk.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer_sdk.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdevc.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdoc.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartfmt.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/pub.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/pub_sdk.bat View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Jacob
3 years, 9 months ago (2017-03-22 00:07:54 UTC) #2
Bob Nystrom
Can you make the same change to the other .bat files in /bin too? LGTM
3 years, 9 months ago (2017-03-22 00:11:19 UTC) #3
Jacob
updated all the batch files
3 years, 9 months ago (2017-03-22 00:16:40 UTC) #4
Bob Nystrom
lgtm
3 years, 9 months ago (2017-03-22 00:17:21 UTC) #5
Bill Hesse
LGTM
3 years, 9 months ago (2017-03-27 20:45:17 UTC) #6
Jacob
3 years, 8 months ago (2017-03-28 15:30:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b5d53b5348cf8aad8a63b6414374bc07584b03a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698