Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: components/sessions/content/content_serialized_navigation_driver_unittest.cc

Issue 2759333002: Move chrome-specific SerializedNavigation code to chrome/. (Closed)
Patch Set: Fix Android Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/content/content_serialized_navigation_driver_unittest.cc
diff --git a/components/sessions/content/content_serialized_navigation_driver_unittest.cc b/components/sessions/content/content_serialized_navigation_driver_unittest.cc
index 67a34512d8cd3cf2e86a7e711ae4b3d5fcfeffa2..74e4addef9c089c55a419660dc140e7ff36823af 100644
--- a/components/sessions/content/content_serialized_navigation_driver_unittest.cc
+++ b/components/sessions/content/content_serialized_navigation_driver_unittest.cc
@@ -6,10 +6,7 @@
#include "components/sessions/core/serialized_navigation_entry.h"
#include "components/sessions/core/serialized_navigation_entry_test_helper.h"
-#include "content/public/common/page_state.h"
#include "testing/gtest/include/gtest/gtest.h"
-#include "third_party/WebKit/public/platform/WebReferrerPolicy.h"
-#include "ui/base/page_transition_types.h"
namespace sessions {
@@ -41,80 +38,4 @@ TEST(ContentSerializedNavigationDriverTest, PickleSanitizationNoPostData) {
EXPECT_EQ(test_data::kEncodedPageState, sanitized_page_state);
}
-// Tests that the input data is left unsanitized when the referrer policy is
-// Always.
-TEST(ContentSerializedNavigationDriverTest, SanitizeWithReferrerPolicyAlways) {
- ContentSerializedNavigationDriver* driver =
- ContentSerializedNavigationDriver::GetInstance();
- SerializedNavigationEntry navigation =
- SerializedNavigationEntryTestHelper::CreateNavigationForTest();
- SerializedNavigationEntryTestHelper::SetReferrerPolicy(
- blink::WebReferrerPolicyAlways, &navigation);
-
- content::PageState page_state =
- content::PageState::CreateFromURL(test_data::kVirtualURL);
- SerializedNavigationEntryTestHelper::SetEncodedPageState(
- page_state.ToEncodedData(), &navigation);
-
- driver->Sanitize(&navigation);
- EXPECT_EQ(test_data::kIndex, navigation.index());
- EXPECT_EQ(test_data::kUniqueID, navigation.unique_id());
- EXPECT_EQ(test_data::kReferrerURL, navigation.referrer_url());
- EXPECT_EQ(blink::WebReferrerPolicyAlways, navigation.referrer_policy());
- EXPECT_EQ(test_data::kVirtualURL, navigation.virtual_url());
- EXPECT_EQ(test_data::kTitle, navigation.title());
- EXPECT_EQ(page_state.ToEncodedData(), navigation.encoded_page_state());
- EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
- navigation.transition_type(), test_data::kTransitionType));
- EXPECT_EQ(test_data::kHasPostData, navigation.has_post_data());
- EXPECT_EQ(test_data::kPostID, navigation.post_id());
- EXPECT_EQ(test_data::kOriginalRequestURL, navigation.original_request_url());
- EXPECT_EQ(test_data::kIsOverridingUserAgent,
- navigation.is_overriding_user_agent());
- EXPECT_EQ(test_data::kTimestamp, navigation.timestamp());
- EXPECT_EQ(test_data::kSearchTerms, navigation.search_terms());
- EXPECT_EQ(test_data::kFaviconURL, navigation.favicon_url());
- EXPECT_EQ(test_data::kHttpStatusCode, navigation.http_status_code());
-}
-
-// Tests that the input data is properly sanitized when the referrer policy is
-// Never.
-TEST(ContentSerializedNavigationDriverTest, SanitizeWithReferrerPolicyNever) {
- ContentSerializedNavigationDriver* driver =
- ContentSerializedNavigationDriver::GetInstance();
- SerializedNavigationEntry navigation =
- SerializedNavigationEntryTestHelper::CreateNavigationForTest();
- SerializedNavigationEntryTestHelper::SetReferrerPolicy(
- blink::WebReferrerPolicyNever, &navigation);
-
- content::PageState page_state =
- content::PageState::CreateFromURL(test_data::kVirtualURL);
- SerializedNavigationEntryTestHelper::SetEncodedPageState(
- page_state.ToEncodedData(), &navigation);
-
- driver->Sanitize(&navigation);
-
- // Fields that should remain untouched.
- EXPECT_EQ(test_data::kIndex, navigation.index());
- EXPECT_EQ(test_data::kUniqueID, navigation.unique_id());
- EXPECT_EQ(test_data::kVirtualURL, navigation.virtual_url());
- EXPECT_EQ(test_data::kTitle, navigation.title());
- EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
- navigation.transition_type(), test_data::kTransitionType));
- EXPECT_EQ(test_data::kHasPostData, navigation.has_post_data());
- EXPECT_EQ(test_data::kPostID, navigation.post_id());
- EXPECT_EQ(test_data::kOriginalRequestURL, navigation.original_request_url());
- EXPECT_EQ(test_data::kIsOverridingUserAgent,
- navigation.is_overriding_user_agent());
- EXPECT_EQ(test_data::kTimestamp, navigation.timestamp());
- EXPECT_EQ(test_data::kSearchTerms, navigation.search_terms());
- EXPECT_EQ(test_data::kFaviconURL, navigation.favicon_url());
- EXPECT_EQ(test_data::kHttpStatusCode, navigation.http_status_code());
-
- // Fields that were sanitized.
- EXPECT_EQ(GURL(), navigation.referrer_url());
- EXPECT_EQ(blink::WebReferrerPolicyDefault, navigation.referrer_policy());
- EXPECT_EQ(page_state.ToEncodedData(), navigation.encoded_page_state());
-}
-
} // namespace sessions

Powered by Google App Engine
This is Rietveld 408576698