Move chrome-specific SerializedNavigation code to chrome/.

components/sessions/core/serialized_navigation_driver.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_DRIVER_H_
 #define COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_DRIVER_H_
 
 #include <string>
 
+#include "base/callback.h"
 #include "components/sessions/core/sessions_export.h"
 
 namespace sessions {
 
 class SerializedNavigationEntry;
 
 // The SerializedNavigationDriver interface allows SerializedNavigationEntry to
 // obtain information from a singleton driver object. A concrete implementation
 // must be provided by the driver on each platform.
 class SESSIONS_EXPORT SerializedNavigationDriver {
  public:
-  virtual ~SerializedNavigationDriver() {}
+  using SanitizeCallback = base::Callback<void(SerializedNavigationEntry*)>;

[sky, 2017/03/21 14:47:39]

This seems like a roundabout way of overriding Sanitize. How come you didn't
make chrome code subclass ContentSerializedNavigationDriver and override
Sanitize?

[Lei Zhang, 2017/03/21 17:12:51]

Wouldn't I need to move SerializedNavigationDriver::Get() and
ContentSerializedNavigationDriver::GetInstance() out of components/ then?

[sky, 2017/03/21 17:50:59]

Good point. How about having setters that content and chrome call?

 
   // Returns the singleton SerializedNavigationDriver.
   static SerializedNavigationDriver* Get();
 
+  // Sets the callback to use for Sanitize().
+  static void SetSanitizeCallback(const SanitizeCallback& callback);
+
   // Returns the default referrer policy.
   virtual int GetDefaultReferrerPolicy() const = 0;
 
   // Maps current referrer policies to old values to work around
   // crbug.com/450589. Returns false if the referrer should be stripped.
   virtual bool MapReferrerPolicyToOldValues(
       int referrer_policy,
       int* mapped_referrer_policy) const = 0;
 
   // Sanitizes a referrer policy that might either be in the old or the new
   // format. Returns false if the referrer should be stripped.
   virtual bool MapReferrerPolicyToNewValues(
       int referrer_policy,
       int* mapped_referrer_policy) const = 0;
 
   // Returns a sanitized version of the given |navigation|'s encoded_page_state
   // suitable for writing to disk.
   virtual std::string GetSanitizedPageStateForPickle(
       const SerializedNavigationEntry* navigation) const = 0;
 
   // Sanitizes the data in the given |navigation| to be more robust against
   // faulty data written by older versions.
   virtual void Sanitize(SerializedNavigationEntry* navigation) const = 0;
 
   // Removes the referrer from the encoded page state.
   virtual std::string StripReferrerFromPageState(
       const std::string& page_state) const = 0;
+
+ protected:
+  virtual ~SerializedNavigationDriver() {}
 };
 
 }  // namespace sessions
 
 #endif  // COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_DRIVER_H_