Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 27593003: Don't hard-code python path. (Closed)

Created:
7 years, 2 months ago by Michael Moss
Modified:
7 years, 1 month ago
Reviewers:
Mark Mentovai, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Don't hard-code python path. Recently upgraded Macs have Python 2.7 in /usr/local/bin and the hard-coded path is breaking the compile step. R=mark@chromium.org BUG=304948 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229375

Patch Set 1 #

Patch Set 2 : fix upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/mac/strip_save_dsym View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Michael Moss
7 years, 2 months ago (2013-10-16 22:05:30 UTC) #1
Michael Moss
7 years, 2 months ago (2013-10-17 15:59:30 UTC) #2
M-A Ruel
lgtm (but you'll want to upload again)
7 years, 2 months ago (2013-10-17 16:02:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/27593003/10001
7 years, 2 months ago (2013-10-17 16:13:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/27593003/10001
7 years, 2 months ago (2013-10-18 01:49:12 UTC) #5
commit-bot: I haz the power
Change committed as 229375
7 years, 2 months ago (2013-10-18 12:22:10 UTC) #6
Mark Mentovai
LGTM, but > Recently upgraded Macs have Python 2.7 in /usr/local/bin and the > hard-coded ...
7 years, 1 month ago (2013-10-25 20:37:07 UTC) #7
Michael Moss
7 years, 1 month ago (2013-10-25 20:39:21 UTC) #8
Message was sent while issue was closed.
On 2013/10/25 20:37:07, Mark Mentovai wrote:
> LGTM, but
> 
> > Recently upgraded Macs have Python 2.7 in /usr/local/bin and the
> > hard-coded path is breaking the compile step.
> 
> Huh? Who broke /usr/bin/python? That should always be there and should always

Uh, sysadmins I guess? I assume it's the result of
https://code.google.com/p/chromium/issues/detail?id=279482

> work. Who says /usr/local/bin is even in the PATH? On a fresh OS install,
> /usr/bin is the first thing in the PATH, and /usr/local/bin is the last.

Powered by Google App Engine
This is Rietveld 408576698