components/payments_strings.grdp - Issue 2759283002: Make payment manifest download/parse cross-platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/payments_strings.grdp

Issue 2759283002: Make payment manifest download/parse cross-platform (Closed)

Patch Set: Address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/payments_strings.grdp

diff --git a/components/payments_strings.grdp b/components/payments_strings.grdp

index 671e5c99b68ec42a4287d79c5cd058bf71302303..48c34cfd07f2ab3ddba01848d6931a85dbc133e8 100644

--- a/components/payments_strings.grdp

+++ b/components/payments_strings.grdp

@@ -249,11 +249,11 @@

Unable to launch payment app.

</message>

- <if expr="is_android">

- <message name="IDS_UTILITY_PROCESS_MANIFEST_PARSER_NAME" desc="The name of the utility process used for parsing manifest files.">

- Manifest Parser

+ <message name="IDS_UTILITY_PROCESS_PAYMENT_MANIFEST_PARSER_NAME" desc="The name of the utility process used for parsing manifest files.">

+ Payment Manifest Parser

</message>

- <message name="IDS_EXTERNAL_PAYMENT_APP_LEAVE_INCOGNITO_WARNING" desc="Alert dialog text warning the user that incognito mode does not conitnue into external payment apps." formatter_data="android_java">

+ <if expr="is_android">

+ <message name="IDS_EXTERNAL_PAYMENT_APP_LEAVE_INCOGNITO_WARNING" desc="Alert dialog text warning the user that incognito mode does not continue into external payment apps." formatter_data="android_java">

Leaving incognito mode to pay via an external application. Continue?

</message>

</if>

« no previous file with comments | « components/payments/content/utility/payment_manifest_parser_unittest.cc ('k') | content/browser/BUILD.gn » ('j') | no next file with comments »