Add image-first-tests flag to run-webkit-tests

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Szeged
 # Copyright (C) 2011 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 217 matching lines @@
                       'you might miss new crashes in these tests.')),
             optparse.make_option(
                 '--smoke',
                 action='store_true',
                 help='Run just the SmokeTests'),
             optparse.make_option(
                 '--no-smoke',
                 dest='smoke',
                 action='store_false',
                 help='Do not run just the SmokeTests'),
+            optparse.make_option(
+                '--image-first-tests',
+                action='append',
+                default=[],
+                dest='image_first_tests',
+                help='directories or test that will be only checked for image'
+                ' expectation if it\'s available and fall back to test '
+                'expectation if image expectation is missing (may specify '
+                'multiple times)'),

[qyearsley, 2017/03/21 22:44:09]

This help text could probably be made a bit clearer. Does it sound correct to
say:
"A directory (or test) where the test result will only be compared with the
image baseline if an image baseline is available, and fall back to comparison
with the text baseline when image baselines are missing. Specify multiple times
to add multiple directories." 

Since this argument is sort of parallel to --pixel-test-directory, you could
also change the option name and dest etc. to be more like
--pixel-test-directory.

            optparse.make_option(
                '--image-first-directory',
                action='append',
                default=[],
                dest='image_first_directories',
                help=('A directory (or test) where the test result will '
                      'only be compared with the image baseline if an image '
                      'baseline is available, and fall back to comparison '
                      'with the text baseline when image baselines are missing.
'
                      'Specify multiple times to add multiple directories.')),

         ]))
 
     option_group_definitions.append(
         ('Testing Options', [
             optparse.make_option(
                 '--additional-env-var',
                 type='string',
                 action='append',
                 default=[],
                 help=('Passes that environment variable to the tests '
@@ skipping 338 matching lines @@
             _log.debug('\t%s', process)
 
         return run_details
 
     finally:
         printer.cleanup()
 
 if __name__ == '__main__':
     exit_code = main(sys.argv[1:], sys.stdout, sys.stderr)
     sys.exit(exit_code)