[Web Payments] Implement item selection in lists.

chrome/browser/ui/views/payments/shipping_option_view_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/shipping_option_view_controller.h"
 
 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
 #include "components/payments/content/payment_request_spec.h"
 #include "components/payments/content/payment_request_state.h"
 
@@ skipping 13 matching lines @@
   ~ShippingOptionItem() override {}
 
  private:
   // payments::PaymentRequestItemList::Item:
   std::unique_ptr<views::View> CreateContentView() override {
     return CreateShippingOptionLabel(
         shipping_option_,
         spec()->GetFormattedCurrencyAmount(shipping_option_->amount->value));
   }
 
-  void SelectedStateChanged() override {}
+  void SelectedStateChanged() override {

[Mathieu, 2017/03/21 13:56:59]

We always seem to use SelectedStateChanged + selected() - unless I'm wrong. If
this is true perhaps the call should be "item is now selected"?

[anthonyvd, 2017/03/21 14:56:06]

Yeah I thought about this too. I think it just happens that *now* we only do
stuff when the item is selected but conceptually it makes sense to notify items
when they're deselected as well (for example, some items might want to modify
how they look depending on whether they're selected or not).

+    if (selected())
+      state()->SetSelectedShippingOption(shipping_option_);
+  }
 
   bool CanBeSelected() const override {
     // Shipping options are vetted by the website; they're all OK to select.
     return true;
   }
 
   void PerformSelectionFallback() override {
     // Since CanBeSelected() is always true, this should never be called.
     NOTREACHED();
   }
 
   mojom::PaymentShippingOption* shipping_option_;
 
   DISALLOW_COPY_AND_ASSIGN(ShippingOptionItem);
 };
 
 }  // namespace
 
 ShippingOptionViewController::ShippingOptionViewController(
     PaymentRequestSpec* spec,
     PaymentRequestState* state,
     PaymentRequestDialogView* dialog)
-    : PaymentRequestSheetController(spec, state, dialog) {
+    : PaymentRequestSheetController(spec, state, dialog),
+      shipping_option_list_(dialog) {
   for (const auto& option : spec->details().shipping_options) {
     shipping_option_list_.AddItem(base::MakeUnique<ShippingOptionItem>(
         option.get(), spec, state, &shipping_option_list_,
         option.get() == state->selected_shipping_option()));
   }
 }
 
 ShippingOptionViewController::~ShippingOptionViewController() {}
 
 std::unique_ptr<views::View> ShippingOptionViewController::CreateView() {
   std::unique_ptr<views::View> list_view =
       shipping_option_list_.CreateListView();
   return CreatePaymentView(
       CreateSheetHeaderView(
           true, GetShippingOptionSectionString(spec()->options().shipping_type),
           this),
       std::move(list_view));
 }
 
 std::unique_ptr<views::View>
 ShippingOptionViewController::CreateExtraFooterView() {
   return nullptr;
 }
 
 }  // namespace payments