Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

Issue 2759243002: [wrapper-tracing] Emite write barrier upon associating a wrapper (Closed)
Patch Set: Unconditionally mark during tracing without checking backpointer for SW Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
index a8763a8eeb07fc6b387d303ec8a469b38e74f240..7b86172520078b8a3ea5dba3392471d851fabd3a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
@@ -5,10 +5,10 @@
#ifndef ScriptWrappableVisitor_h
#define ScriptWrappableVisitor_h
-#include "bindings/core/v8/ScriptWrappable.h"
#include "core/CoreExport.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/heap/HeapPage.h"
+#include "platform/heap/VisitorImpl.h"
#include "platform/heap/WrapperVisitor.h"
#include "v8/include/v8.h"
#include "wtf/Deque.h"
@@ -19,6 +19,7 @@ namespace blink {
class HeapObjectHeader;
template <typename T>
class Member;
+class ScriptWrappable;
template <typename T>
class TraceWrapperV8Reference;
@@ -99,6 +100,10 @@ class CORE_EXPORT ScriptWrappableVisitor : public v8::EmbedderHeapTracer,
static void writeBarrier(const void*,
const TraceWrapperV8Reference<v8::Value>*);
+ // TODO(mlippautz): Remove once ScriptWrappable is converted to
+ // TraceWrapperV8Reference.
+ static void writeBarrier(const v8::Persistent<v8::Object>*);
+
template <typename T>
static void writeBarrier(const void* object, const Member<T> value) {
writeBarrier(object, value.get());

Powered by Google App Engine
This is Rietveld 408576698