Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 2759243002: [wrapper-tracing] Emite write barrier upon associating a wrapper (Closed)
Patch Set: Unconditionally mark during tracing without checking backpointer for SW Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef ScriptWrappable_h 31 #ifndef ScriptWrappable_h
32 #define ScriptWrappable_h 32 #define ScriptWrappable_h
33 33
34 #include "bindings/core/v8/ScriptWrappableVisitor.h"
34 #include "bindings/core/v8/WrapperTypeInfo.h" 35 #include "bindings/core/v8/WrapperTypeInfo.h"
35 #include "core/CoreExport.h" 36 #include "core/CoreExport.h"
36 #include "platform/heap/Handle.h" 37 #include "platform/heap/Handle.h"
37 #include "v8/include/v8.h" 38 #include "v8/include/v8.h"
38 #include "wtf/Compiler.h" 39 #include "wtf/Compiler.h"
39 #include "wtf/Noncopyable.h" 40 #include "wtf/Noncopyable.h"
40 #include "wtf/TypeTraits.h" 41 #include "wtf/TypeTraits.h"
41 42
42 namespace blink { 43 namespace blink {
43 44
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 v8::Local<v8::Object>& wrapper) { 119 v8::Local<v8::Object>& wrapper) {
119 ASSERT(!wrapper.IsEmpty()); 120 ASSERT(!wrapper.IsEmpty());
120 if (UNLIKELY(containsWrapper())) { 121 if (UNLIKELY(containsWrapper())) {
121 wrapper = mainWorldWrapper(isolate); 122 wrapper = mainWorldWrapper(isolate);
122 return false; 123 return false;
123 } 124 }
124 m_mainWorldWrapper.Reset(isolate, wrapper); 125 m_mainWorldWrapper.Reset(isolate, wrapper);
125 wrapperTypeInfo->configureWrapper(&m_mainWorldWrapper); 126 wrapperTypeInfo->configureWrapper(&m_mainWorldWrapper);
126 m_mainWorldWrapper.SetWeak(); 127 m_mainWorldWrapper.SetWeak();
127 ASSERT(containsWrapper()); 128 ASSERT(containsWrapper());
129 ScriptWrappableVisitor::writeBarrier(&m_mainWorldWrapper);
128 return true; 130 return true;
129 } 131 }
130 132
131 bool isEqualTo(const v8::Local<v8::Object>& other) const { 133 bool isEqualTo(const v8::Local<v8::Object>& other) const {
132 return m_mainWorldWrapper == other; 134 return m_mainWorldWrapper == other;
133 } 135 }
134 136
135 // Provides a way to convert Node* to ScriptWrappable* without including 137 // Provides a way to convert Node* to ScriptWrappable* without including
136 // "core/dom/Node.h". 138 // "core/dom/Node.h".
137 // 139 //
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 #define DECLARE_WRAPPERTYPEINFO() \ 213 #define DECLARE_WRAPPERTYPEINFO() \
212 public: \ 214 public: \
213 const WrapperTypeInfo* wrapperTypeInfo() const override; \ 215 const WrapperTypeInfo* wrapperTypeInfo() const override; \
214 \ 216 \
215 private: \ 217 private: \
216 typedef void end_of_define_wrappertypeinfo_not_reached_t 218 typedef void end_of_define_wrappertypeinfo_not_reached_t
217 219
218 } // namespace blink 220 } // namespace blink
219 221
220 #endif // ScriptWrappable_h 222 #endif // ScriptWrappable_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698