Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2759173002: Switch to IdentifierContext. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch to IdentifierContext.

Patch Set 1 #

Patch Set 2 : Rebased on 7b8f3f27a50b0348acaa90b96e9c53383b1482e9. #

Patch Set 3 : Adjust this/super and type handling. #

Patch Set 4 : Status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -303 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/builder.dart View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/class_builder.dart View 1 2 3 2 chunks +15 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/dynamic_type_builder.dart View 1 2 3 1 chunk +4 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/formal_parameter_builder.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/member_builder.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/metadata_builder.dart View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/mixed_accessor.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/prefix_builder.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/scope.dart View 1 2 3 5 chunks +29 lines, -17 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/type_builder.dart View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 2 3 20 chunks +52 lines, -58 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart View 1 2 3 6 chunks +51 lines, -31 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_variable_builder.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/identifier_context.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 2 10 chunks +16 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/static.dart View 1 2 3 2 chunks +65 lines, -62 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/static.dart.direct.expect View 1 2 3 2 chunks +67 lines, -62 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 2 3 4 chunks +0 lines, -10 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 3 5 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahe
3 years, 9 months ago (2017-03-20 16:34:07 UTC) #2
Paul Berry
lgtm
3 years, 9 months ago (2017-03-20 16:54:10 UTC) #3
ahe
Johnni, Could you take a look. I found some issues when I ran the full ...
3 years, 9 months ago (2017-03-21 09:58:17 UTC) #6
ahe
On 2017/03/21 09:58:17, ahe wrote: > Johnni, Could you take a look. I found some ...
3 years, 9 months ago (2017-03-21 10:51:44 UTC) #7
ahe
3 years, 9 months ago (2017-03-21 14:44:47 UTC) #8 
I've reached the bottom of the rabbit hole, but I'm going to abandon this CL and
split it up into more digestible parts.

Powered by Google App Engine
This is Rietveld 408576698