Issue 275913002: Use the root locale instead of the system default locale.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 275913002: Use the root locale instead of the system default locale. (Closed)

Created:
6 years, 7 months ago by roubert

Modified:
6 years, 7 months ago

Reviewers:
please use gerrit instead

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Use the root locale instead of the system default locale. ChromeStringCanonicalizer does case and diacritic insensitive string comparison through an ICU Collator. To get general Unicode character rules, the root locale should be used. The system default locale is different from system to system, and using that will cause the code to break when executed on a system where it doesn't have the properties that this code assumes. This change also adds #include statemens for all ICU header files from which the code in this file uses declarations. R=rouslan@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269601