[interpreter] Split out intrinsics generation

src/interpreter/interpreter-intrinsics.h

Index: src/interpreter/interpreter-intrinsics.h
diff --git a/src/interpreter/interpreter-intrinsics.h b/src/interpreter/interpreter-intrinsics.h
index 502a2f7b38cc4d8711f3c6fed3ea8d5a70ebbdc2..86e4a1c10ecc35a218b257ad57f3456713210c88 100644
--- a/src/interpreter/interpreter-intrinsics.h
+++ b/src/interpreter/interpreter-intrinsics.h
@@ -5,20 +5,10 @@
 #ifndef V8_INTERPRETER_INTERPRETER_INTRINSICS_H_
 #define V8_INTERPRETER_INTERPRETER_INTRINSICS_H_
 
-#include "src/allocation.h"
-#include "src/builtins/builtins.h"
-#include "src/frames.h"
-#include "src/interpreter/bytecodes.h"
-#include "src/interpreter/interpreter-assembler.h"
 #include "src/runtime/runtime.h"
 
 namespace v8 {
 namespace internal {
-
-namespace compiler {
-class Node;
-}  // namespace compiler
-
 namespace interpreter {
 
 // List of supported intrisics, with upper case name, lower case name and
@@ -51,44 +41,11 @@ class IntrinsicsHelper {
   };
   STATIC_ASSERT(static_cast<uint32_t>(IntrinsicId::kIdCount) <= kMaxUInt8);
 
-  explicit IntrinsicsHelper(InterpreterAssembler* assembler);
-
-  compiler::Node* InvokeIntrinsic(compiler::Node* function_id,
-                                  compiler::Node* context,
-                                  compiler::Node* first_arg_reg,
-                                  compiler::Node* arg_count);
-
   static bool IsSupported(Runtime::FunctionId function_id);
   static IntrinsicId FromRuntimeId(Runtime::FunctionId function_id);
   static Runtime::FunctionId ToRuntimeId(IntrinsicId intrinsic_id);
 
  private:
-  enum InstanceTypeCompareMode {
-    kInstanceTypeEqual,
-    kInstanceTypeGreaterThanOrEqual
-  };
-
-  compiler::Node* IsInstanceType(compiler::Node* input, int type);
-  compiler::Node* CompareInstanceType(compiler::Node* map, int type,
-                                      InstanceTypeCompareMode mode);
-  compiler::Node* IntrinsicAsStubCall(compiler::Node* input,
-                                      compiler::Node* context,
-                                      Callable const& callable);
-  void AbortIfArgCountMismatch(int expected, compiler::Node* actual);
-
-#define DECLARE_INTRINSIC_HELPER(name, lower_case, count)                \
-  compiler::Node* name(compiler::Node* input, compiler::Node* arg_count, \
-                       compiler::Node* context);
-  INTRINSICS_LIST(DECLARE_INTRINSIC_HELPER)
-#undef DECLARE_INTRINSIC_HELPER
-
-  Isolate* isolate() { return isolate_; }
-  Zone* zone() { return zone_; }
-
-  Isolate* isolate_;
-  Zone* zone_;
-  InterpreterAssembler* assembler_;
-
   DISALLOW_COPY_AND_ASSIGN(IntrinsicsHelper);

[rmcilroy, 2017/03/20 18:17:11]

nit - DISALLOW_IMPLICIT_CONSTRUCTORS

[Jakob Kummerow, 2017/03/21 11:20:53]

Done.

 };