ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html - Issue 2759073002: MD Webui: Improve accessibility of toolbar search field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Issue 2759073002: MD Webui: Improve accessibility of toolbar search field (Closed)

Patch Set: Use toString Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

diff --git a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

index c274e197e1c481a08800fbd6babfb6880411a0d0..4b654d763aab5489832d1e6eb9b0f07e91fe93f9 100644

--- a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

+++ b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

@@ -134,10 +134,11 @@

</paper-spinner-lite>

</template>

<paper-icon-button id="icon" icon="cr:search" title="[[label]]"

- tabindex$="[[computeIconTabIndex_(narrow)]]">

+ tabindex$="[[computeIconTabIndex_(narrow)]]"

+ aria-hidden$="[[computeIconAriaHidden_(narrow)]]">

</paper-icon-button>

- <label id="prompt" for="searchInput">[[label]]</label>

+ <label id="prompt" for="searchInput" aria-hidden="true">[[label]]</label>

<input id="searchInput"

type="search"

on-input="onSearchTermInput"

« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js » ('j') | no next file with comments »