Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: net/data/verify_certificate_chain_unittest/rebase-errors.py

Issue 2759023002: Improvements to the net/cert/internal error handling. (Closed)
Patch Set: fix comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/data/verify_certificate_chain_unittest/rebase-errors.py
diff --git a/net/data/verify_certificate_chain_unittest/rebase-errors.py b/net/data/verify_certificate_chain_unittest/rebase-errors.py
index 537052afd6fae268af4eac1a1dc3dba3bf698bdf..923757564156b22b9779098ebf8898ad2c3e075c 100755
--- a/net/data/verify_certificate_chain_unittest/rebase-errors.py
+++ b/net/data/verify_certificate_chain_unittest/rebase-errors.py
@@ -15,7 +15,7 @@ To use this run the affected tests, and then pass the input to this script
net/data/verify_certificate_chain_unittest/rebase-errors.py
The script works by scanning the stdout looking for gtest failures when
-comparing "errors.ToDebugString()". The C++ test side should have been
+comparing "errors.ToDebugString(chain)". The C++ test side should have been
instrumented to dump out the test file's path on mismatch.
This script will then update the corresponding file(s) -- a .pem file, and
@@ -33,7 +33,7 @@ import re
# * Group 2 of the match is file path (relative to //src) where the expected
# errors were read from.
failed_test_regex = re.compile(r"""
-Value of: errors.ToDebugString\(\)
+Value of: errors.ToDebugString\((?:chain)?\)
Actual: "(.*)"
(?:.|\n)+?
Test file: (.*)

Powered by Google App Engine
This is Rietveld 408576698