Improvements to the net/cert/internal error handling.

net/tools/cert_verify_tool/verify_using_path_builder.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/cert_verify_tool/verify_using_path_builder.h"
 
 #include <iostream>
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 116 matching lines @@
   if (!net::ParseNameValue(trust_anchor->normalized_subject(), &parsed_subject))
     return std::string();
   return SubjectToString(parsed_subject);
 }
 
 // Dumps a ResultPath to std::cout.
 void PrintResultPath(const net::CertPathBuilder::ResultPath* result_path,
                      size_t index,
                      bool is_best) {
   std::cout << "path " << index << " "
-            << (result_path->valid ? "valid" : "invalid")
+            << (result_path->IsValid() ? "valid" : "invalid")
             << (is_best ? " (best)" : "") << "\n";
 
   // Print the certificate chain.
   for (const auto& cert : result_path->path.certs) {
     std::cout << " " << FingerPrintParsedCertificate(cert.get()) << " "
               << SubjectFromParsedCertificate(cert.get()) << "\n";
   }
 
   // Print the trust anchor (if there was one).
   const auto& trust_anchor = result_path->path.trust_anchor;
   if (trust_anchor) {
     std::string trust_anchor_cert_fingerprint = "<no cert>";
     if (trust_anchor->cert()) {
       trust_anchor_cert_fingerprint =
           FingerPrintParsedCertificate(trust_anchor->cert().get());
     }
     std::cout << " " << trust_anchor_cert_fingerprint << " "
               << SubjectFromTrustAnchor(trust_anchor.get()) << "\n";
   }
 
-  // Print the errors.
-  if (!result_path->errors.empty()) {
+  // Print the errors/warnings if there were any.
+  std::string errors_str =
+      result_path->errors.ToDebugString(result_path->path.certs);
+  if (!errors_str.empty()) {
     std::cout << "Errors:\n";
-    std::cout << result_path->errors.ToDebugString() << "\n";
+    std::cout << errors_str << "\n";
   }
 }
 
 scoped_refptr<net::ParsedCertificate> ParseCertificate(const CertInput& input) {
   net::CertErrors errors;
   scoped_refptr<net::ParsedCertificate> cert = net::ParsedCertificate::Create(
       net::x509_util::CreateCryptoBuffer(input.der_cert), {}, &errors);
   if (!cert) {
     PrintCertError("ERROR: ParsedCertificate failed:", input);
     std::cout << errors.ToDebugString() << "\n";
@@ skipping 142 matching lines @@
     if (!DumpParsedCertificateChain(
             dump_prefix_path.AddExtension(
                 FILE_PATH_LITERAL(".CertPathBuilder.pem")),
             result.paths[result.best_result_index]->path)) {
       return false;
     }
   }
 
   return result.HasValidPath();
 }